Skip to content

Explicit instructions for expected result format #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025

Conversation

ShriHumrudha
Copy link
Contributor

GitHub issue number

#106

Associated Risks

None

PR Checklist

  • I have read the contribution guidelines
  • I have read the code of conduct guidelines
  • Title of the pull request is clear and informative.
  • 👌 Code hygiene
  • 🔭 Telemetry added, updated, or N/A
  • 📄 Documentation added, updated, or N/A
  • 🛡️ Automated tests added, or N/A

🧪 How did you test it?

image image

@ShriHumrudha ShriHumrudha requested a review from a team as a code owner August 4, 2025 05:45
@ShriHumrudha
Copy link
Contributor Author

@ShriHumrudha please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="Microsoft"]

@ShriHumrudha
Copy link
Contributor Author

@ShriHumrudha the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company=Microsoft

@danhellem danhellem added Needs Review 👓 needs review by the product team Test Plans 🧪 test plans area labels Aug 4, 2025
skmanoj
skmanoj previously approved these changes Aug 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@c7ac0ef). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage        ?   91.55%           
=======================================
  Files           ?       13           
  Lines           ?      841           
  Branches        ?      143           
=======================================
  Hits            ?      770           
  Misses          ?       40           
  Partials        ?       31           
Flag Coverage Δ
unittests 91.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danhellem
Copy link
Contributor

@ShriHumrudha lets please get the formatting issues fixed so we can merge

@danhellem danhellem merged commit 0e2565c into microsoft:main Aug 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review 👓 needs review by the product team Test Plans 🧪 test plans area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestPlan - test step expected results are hard coded - need to get them back from the prompt
4 participants