Add unittests for previewFeature #287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roaa Sakr <[email protected]>
romoh
changed the title
cwize1
requested changes
Jun 24, 2025
| invalidFeature := PreviewFeature("invalid-feature") | ||
| err := invalidFeature.IsValid() | ||
| assert.Error(t, err) | ||
| assert.Contains(t, err.Error(), "invalid-feature") |
There was a problem hiding this comment.
Use assert.ErrorContains instead of assert.Error and assert.Contains.
| assert.Error(t, err) | ||
| assert.Contains(t, err.Error(), "invalid-feature") | ||
|
|
||
| // Test PreviewFeatureReinitializeVerity is not valid (since it's not typed as PreviewFeature) |
There was a problem hiding this comment.
The reason why this fails is because PreviewFeatureReinitializeVerity is missing in the PreviewFeature.IsValid() function. Go is happily doing the type-cast without issue.
Also, it looks like the Config.PreviewFeatures field isn't being checked for validity. Hence, why this wasn't causing any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code coverage
fixes #279
Checklist