Add unit tests for PreviewFeature with bug fixes

toolkit/tools/imagecustomizerapi/previewfeaturetype.go

@@ -18,7 +18,7 @@ const (
 	PreviewFeatureInjectFiles PreviewFeature = "inject-files"
 
 	// PreviewFeatureReinitializeVerity will reinitialize verity on verity partitions in the base image.
-	PreviewFeatureReinitializeVerity = "reinitialize-verity"
+	PreviewFeatureReinitializeVerity PreviewFeature = "reinitialize-verity"
 
 	// PreviewFeatureSnapshotTime enables support for snapshot-based package filtering.
 	PreviewFeaturePackageSnapshotTime PreviewFeature = "package-snapshot-time"
@@ -29,8 +29,8 @@ const (
 
 func (pf PreviewFeature) IsValid() error {
 	switch pf {
-	case PreviewFeatureUki, PreviewFeatureOutputArtifacts, PreviewFeatureInjectFiles, PreviewFeaturePackageSnapshotTime,
-		PreviewFeatureKdumpBootFiles:
+	case PreviewFeatureUki, PreviewFeatureOutputArtifacts, PreviewFeatureInjectFiles, PreviewFeatureReinitializeVerity,
+		PreviewFeaturePackageSnapshotTime, PreviewFeatureKdumpBootFiles:
 		return nil
 	default:
 		return fmt.Errorf("invalid preview feature: %s", pf)

toolkit/tools/imagecustomizerapi/previewfeaturetype_test.go

@@ -0,0 +1,54 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+package imagecustomizerapi
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestPreviewFeatureUki_IsValid(t *testing.T) {
+	err := PreviewFeatureUki.IsValid()
+	assert.NoError(t, err)
+}
+
+func TestPreviewFeatureOutputArtifacts_IsValid(t *testing.T) {
+	err := PreviewFeatureOutputArtifacts.IsValid()
+	assert.NoError(t, err)
+}
+
+func TestPreviewFeatureInjectFiles_IsValid(t *testing.T) {
+	err := PreviewFeatureInjectFiles.IsValid()
+	assert.NoError(t, err)
+}
+
+func TestPreviewFeatureReinitializeVerity_IsValid(t *testing.T) {
+	err := PreviewFeatureReinitializeVerity.IsValid()
+	assert.NoError(t, err)
+}
+
+func TestPreviewFeaturePackageSnapshotTime_IsValid(t *testing.T) {
+	err := PreviewFeaturePackageSnapshotTime.IsValid()
+	assert.NoError(t, err)
+}
+
+func TestPreviewFeatureKdumpBootFiles_IsValid(t *testing.T) {
+	err := PreviewFeatureKdumpBootFiles.IsValid()
+	assert.NoError(t, err)
+}
+
+func TestPreviewFeature_IsValid_InvalidValue(t *testing.T) {
+	invalidFeature := PreviewFeature("invalid-feature")
+	err := invalidFeature.IsValid()
+	assert.Error(t, err)
+	assert.ErrorContains(t, err, "invalid preview feature: invalid-feature")
+}
+
+func TestPreviewFeature_IsValid_EmptyValue(t *testing.T) {
+	emptyFeature := PreviewFeature("")
+	err := emptyFeature.IsValid()
+	assert.Error(t, err)
+	assert.ErrorContains(t, err, "invalid preview feature:")
+}