Skip to content

#402 remove prefixing internal nuget feeds #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#402 remove prefixing internal nuget feeds #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions common-npm-packages/packaging-common/nuget/NuGetConfigHelper2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,6 @@ export class NuGetConfigHelper2 {
// Removing source first
this.removeSourceFromTempNugetConfig(source);

// Cannot add tag that starts with number as a child node of PackageSourceCredentials because of
// Bug in nuget 4.9.1 and dotnet 2.1.500
// https://github.com/NuGet/Home/issues/7517
// https://github.com/NuGet/Home/issues/7524
// so working around this by prefixing source with string
tl.debug('Prefixing internal source feed name ' + source.feedName + ' with feed-');
source.feedName = 'feed-' + source.feedName;

// Re-adding source with creds
this.addSourceWithUsernamePasswordToTempNuGetConfig(source, "VssSessionToken", this.authInfo.internalAuthInfo.accessToken);
}
Expand Down