Fix HelmInstaller@1 when GitHub is unvailable or rate limited#479
Draft
jraycroft wants to merge 3 commits intomicrosoft:mainfrom
Draft
Fix HelmInstaller@1 when GitHub is unvailable or rate limited#479jraycroft wants to merge 3 commits intomicrosoft:mainfrom
jraycroft wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="Novari Health" |
Author
|
Still need to do an end-to-end test of the task on an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes these issues:
#426
microsoft/azure-pipelines-tasks#17569
Summarize the changes made in this PR clearly and concisely. Highlight the purpose and impact of the changes.
When failing to retrieve a list of releases from Helm's GitHub repo, because of rate limiting, GitHub outages or just other transient failures, fail instead of pinning a specific very old version of Helm.
3.1.2 is very, very old now. I don't believe it makes sense to try to fallback to any version, let alone this one.
Package Name
azure-pipelines-tasks-kubernetes-common.
Risk Assessment (Low / Medium / High)
Low.
Documentation Changes Required (Yes / No)
Indicate whether related documentation needs to be updated. Provide links to the updated documentation if applicable.
No
Checklist