Skip to content

HelmInstaller: pick latest stable Helm by excluding prerelease/drafts #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

HelmInstaller: pick latest stable Helm by excluding prerelease/drafts #491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8178575
kubernetes-common: getStableHelmVersion - exclude prerelease/draft Gi…
mot256 Sep 3, 2025
78b87fb
Merge branch 'main' into fix/helminstaller-prerelease-filter
mot256 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions common-npm-packages/kubernetes-common/helmutility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,12 @@ export async function getStableHelmVersion(): Promise<string> {
responseArray.forEach(response => {
if (response && response.tag_name) {
let currentHelmVerison = semver.clean(response.tag_name.toString());
if (currentHelmVerison) {
if (currentHelmVerison.toString().indexOf('rc') == -1 && semver.gt(currentHelmVerison, latestHelmVersion)) {
//If current helm version is not a pre release and is greater than latest helm version
if (currentHelmVerison) {
// Exclude any pre-release (alpha, beta, rc, etc.) and drafts.
const isPreRelease = (response.prerelease === true) || !!semver.prerelease(currentHelmVerison);
const isDraft = response.draft === true;
if (!isPreRelease && !isDraft && semver.gt(currentHelmVerison, latestHelmVersion)) {
// If current helm version is stable and greater than latest helm version
latestHelmVersion = currentHelmVerison;
}
}
Expand Down