Null-proof (#12656)

* Null-proof

* Addressed PR comments

Co-authored-by: Aasim Malladi <[email protected]>

Author: johnterickson

Tasks/Common/packaging-common/Strings/resources.resjson/en-US/resources.resjson

@@ -25,5 +25,6 @@
   "loc.messages.NGCommon_UnabletoDetectNuGetVersion": "Unknown NuGet version selected.",
   "loc.messages.NGCommon_UnableToFindTool": "Unable to find tool %s",
   "loc.messages.Warning_SessionCreationFailed": "Could not create provenance session.",
-  "loc.messages.Warning_UpdatingNuGetVersion": "Updating version of NuGet.exe to %s from %s. Behavior changes or breaking changes might occur as NuGet updates to a new version. If this is not desired, uncheck the 'Check for Latest Version' option in the task."
+  "loc.messages.Warning_UpdatingNuGetVersion": "Updating version of NuGet.exe to %s from %s. Behavior changes or breaking changes might occur as NuGet updates to a new version. If this is not desired, uncheck the 'Check for Latest Version' option in the task.",
+  "loc.messages.Warning_IncompatibleNugetMsbuildVersion": "The detected version of MSBuild (%s) is incompatible with NuGet (%s). See https://aka.ms/AA84eyr"
 }

Tasks/Common/packaging-common/module.json

@@ -26,6 +26,7 @@
         "NGCommon_UnabletoDetectNuGetVersion": "Unknown NuGet version selected.",
         "NGCommon_UnableToFindTool": "Unable to find tool %s",
         "Warning_SessionCreationFailed": "Could not create provenance session.",
-        "Warning_UpdatingNuGetVersion": "Updating version of NuGet.exe to %s from %s. Behavior changes or breaking changes might occur as NuGet updates to a new version. If this is not desired, uncheck the 'Check for Latest Version' option in the task."
+        "Warning_UpdatingNuGetVersion": "Updating version of NuGet.exe to %s from %s. Behavior changes or breaking changes might occur as NuGet updates to a new version. If this is not desired, uncheck the 'Check for Latest Version' option in the task.",
+        "Warning_IncompatibleNugetMsbuildVersion": "The detected version of MSBuild (%s) is incompatible with NuGet (%s). See https://aka.ms/AA84eyr"
     }
 }

Tasks/Common/packaging-common/nuget/NuGetToolGetter.ts

@@ -88,6 +88,9 @@ export async function getNuGet(versionSpec: string, checkLatest?: boolean, addNu
     console.log(taskLib.loc("Info_UsingVersion", version));
     toolPath= toolLib.findLocalTool(NUGET_TOOL_NAME, version);
 
+    // Check if NuGet version is incompatible with msbuild
+    issueWarningWhenNuGetIncompatible(version);
+
     if (addNuGetToPath){
         console.log(taskLib.loc("Info_UsingToolPath", toolPath));
         toolLib.prependPath(toolPath);
@@ -99,6 +102,18 @@ export async function getNuGet(versionSpec: string, checkLatest?: boolean, addNu
     return fullNuGetPath;
 }
 
+export async function issueWarningWhenNuGetIncompatible(nugetVersion: string)  {
+    const nugetSemVer = semver.coerce(nugetVersion);
+
+    // invert so the below is not called in unit tests
+    if (!semver.gte(nugetSemVer, '4.8.2')) {
+        const msbuildSemVer = await getMSBuildVersion();
+        if (semver.satisfies(msbuildSemVer, '>=16.5.0')) {
+            taskLib.logIssue(taskLib.IssueType.Warning, taskLib.loc('Warning_IncompatibleNugetMsbuildVersion', msbuildSemVer, nugetSemVer));
+        }
+    }
+}
+
 function pathExistsAsFile(path: string) {
     try {
         return taskLib.stats(path).isFile();
@@ -146,7 +161,7 @@ export async function cacheBundledNuGet(
     if (cachedVersionToUse == null) {
         // Attempt to match nuget.exe version with msbuild.exe version
         const msbuildSemVer = await getMSBuildVersion();
-        if (msbuildSemVer && semver.gte(msbuildSemVer, '16.5.0')) {
+        if (semver.satisfies(msbuildSemVer, '>=16.5.0')) {
             taskLib.debug('Snapping to v5.4.0');
             cachedVersionToUse = '5.4.0';
             nugetPathSuffix = 'NuGet/5.4.0/';

Tasks/DotNetCoreCLIV2/task.json

@@ -17,8 +17,8 @@
     "demands": [],
     "version": {
         "Major": 2,
-        "Minor": 167,
-        "Patch": 7
+        "Minor": 173,
+        "Patch": 0
     },
     "minimumAgentVersion": "2.115.0",
     "instanceNameFormat": "dotnet $(command)",

Tasks/DotNetCoreCLIV2/task.loc.json

@@ -17,8 +17,8 @@
   "demands": [],
   "version": {
     "Major": 2,
-    "Minor": 167,
-    "Patch": 7
+    "Minor": 173,
+    "Patch": 0
   },
   "minimumAgentVersion": "2.115.0",
   "instanceNameFormat": "ms-resource:loc.instanceNameFormat",

Tasks/DownloadPackageV0/task.json

@@ -9,8 +9,8 @@
     "author": "ms-vscs-rm",
     "version": {
         "Major": 0,
-        "Minor": 167,
-        "Patch": 5
+        "Minor": 173,
+        "Patch": 0
     },
     "demands": [],
     "minimumAgentVersion": "1.99.0",

Tasks/DownloadPackageV0/task.loc.json

@@ -9,8 +9,8 @@
   "author": "ms-vscs-rm",
   "version": {
     "Major": 0,
-    "Minor": 167,
-    "Patch": 5
+    "Minor": 173,
+    "Patch": 0
   },
   "demands": [],
   "minimumAgentVersion": "1.99.0",

Tasks/DownloadPackageV1/task.json

@@ -9,8 +9,8 @@
     "author": "ms-vscs-rm",
     "version": {
         "Major": 1,
-        "Minor": 167,
-        "Patch": 5
+        "Minor": 173,
+        "Patch": 0
     },
     "demands": [],
     "releaseNotes": "Adds support to download Maven, Python, Universal and Npm packages.",

Tasks/DownloadPackageV1/task.loc.json

@@ -9,8 +9,8 @@
   "author": "ms-vscs-rm",
   "version": {
     "Major": 1,
-    "Minor": 167,
-    "Patch": 5
+    "Minor": 173,
+    "Patch": 0
   },
   "demands": [],
   "releaseNotes": "ms-resource:loc.releaseNotes",

Tasks/MavenV2/task.json

@@ -17,8 +17,8 @@
     "author": "Microsoft Corporation",
     "version": {
         "Major": 2,
-        "Minor": 167,
-        "Patch": 5
+        "Minor": 173,
+        "Patch": 0
     },
     "releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",
     "demands": [