-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adding Visual Studio 18.0 #21412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adding Visual Studio 18.0 #21412
Conversation
|
Thanks @andysterland for getting this started -- change looks good to me. As we discussed in chat I think this is overly engineering with specific string-looking rather than really relying on |
|
This SqlAzureDacpacDeploymentV1 Task also looks up the presence of VS:
|
|
And I suspect it should target the https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/MSBuildV1/task.json#L57-L65 Which requires updating: |
|
Similar to the comment from @jessehouwing , then I believe that also |
Thanks for pointing that out :). Looking into that file a bit more. It looks like making a change across the board in that file is probably best once VS2026 is released as it looks like that file checks for |
Added. |
|
@timheuer @ToreDemant @jessehouwing Thanks for looking at this PR :). I was thinking of holding off merging until VS2026 releases. |
|
@andysterland These tasks have never supported prerelease/insider release som maybe it is not the biggest problem if they don't after this change either. Perhaps changing the title and description to mention 'Visual Studio 18.0 GA' I do however agree that it would be preferrable if that support could be added too, in another PR of cause. Perhaps it could be done like the environment knob in Azure Pipeline Agent called |
|
It seems that the node module Any idea on how/where that can be updated? |
I think @jessehouwing pointed out they come from: https://github.com/microsoft/azure-pipelines-tasks-common-packages/tree/main/common-npm-packages/msbuildhelpers Started a draft PR for that at: microsoft/azure-pipelines-tasks-common-packages#506 |
|
Arh, of cause, @jessehouwing is as always one step ahead :-) |
|
@andysterland there seem to still be picklists missing from this PR. These are the ones I found:
I found these places by searching for '17' and '2022' as I figured that if they are there then there probably also need to be something for '18' or '2026'. |
I'll take that as a compliment. I'll make sure the task is available for Azure DevOps Server |
Context
Adding VS2026 to the VSBuild@1 task so it can be used as soon the GA release of VS2026 becomes available.
Important This task uses VSWhere to determine what versions of Visual Studio are installed. VSWhere won't find VS2026 Insiders without the
-prereleaseflag. This will cause issues wherever it's assumed-latestwill return18.0. Ergo it might be best to not update this task until VS2026 is GA as plumping through-prereleaseis a much bigger change.#21319
Task Name
VSBuildV1
Description
Adding Visual Studio 2026, 18.0, to the hardcoded list of versions that are available.
Risk Assessment (Low / Medium / High)
Low
Change Behind Feature Flag (Yes / No)
No.
Tech Design / Approach
Copy of the commit 1ab60be and 41450699102924f215268bff661191afe9fe6c3d5703d3a7473db7e4293a2950 that added VS2022 but with +1 on versions :).
Documentation Changes Required (Yes/No)
Yes. Documentation needs to be updated to include 18.0 as a valid version.
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Logging Added/Updated (Yes/No)
No, no change required updated logging.
Telemetry Added/Updated (Yes/No)
No. The task has no telemetry.
Rollback Scenario and Process (Yes/No)
Dependency Impact Assessed and Regression Tested (Yes/No)
Checklist