Refactor npm audit error handling to throw errors instead of silently finish #21418
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
tarunramsinghani
approved these changes
Nov 7, 2025
rishabhmalikMS
approved these changes
Nov 7, 2025
sanjuyadav24
approved these changes
Nov 7, 2025
ivanduplenskikh
force-pushed
the
users/iduplenskikh/fix-perform-audit
branch
from
99e07a3 to
b48b737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The audit perform step was introduced in the PR #21151.
However, there is an issue with checking the
auditResult.errorproperty, as it remains undefined in any cases.Additionally, the proposal message has been corrected
Risk Assessment
Low