Users/sanjuyadav/add node24 buildconfig #21423
Open
+53
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| .concat(fs.existsSync(genTaskPathLocal) ? fs.readdirSync(genTaskPathLocal).map(taskName => path.join(genTaskPathLocal, taskName)) : []); | ||
|
|
||
| const invalidPaths = paths.filter(taskPath => test('-d', taskPath) && !test('-f', path.join(taskPath, 'task.json')) && !taskPath.includes('_buildConfigs')); | ||
| const invalidPaths = paths.filter(taskPath => test('-d', taskPath) && !test('-f', path.join(taskPath, 'task.json')) && !taskPath.includes('_buildConfigs') && !taskPath.endsWith('Common')); |
There was a problem hiding this comment.
Could you please tell the purpose of excluding this !taskPath.endsWith('Common') here.
| } | ||
|
|
||
| private static void WriteNodePackageJson(string taskOutputNode, string nodeVersion, bool shouldUpdateTypescript, bool shouldUpdateTaskLib) | ||
| private static void WriteNodePackageJson(string taskOutputNode, string nodeVersion, bool shouldUpdateTypescript, string? typescriptVersion, bool shouldUpdateTaskLib) |
There was a problem hiding this comment.
It would be a good practice if we keep optional parameter at the end of function definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds complete Node.js 24 support to the Azure Pipelines Tasks build system, enabling task authors to build and deploy tasks that run on Node.js 24.
AB#2328151
Description
This PR implements comprehensive Node.js 24 support across the Azure Pipelines Tasks build system through the following changes:
1. BuildConfigGen Program Updates (
BuildConfigGen/Program.cs)Node24: New standalone config for Node 24 tasks (does not merge to base)Node24_overwrite: Config for migrating existing tasks to Node 24 (merges to base)^24.10.0Node24NODE24^5.7.2Node24-265andNode24-265-overwriteRisk Assessment: Low
Added two additional build configs but these are not used by any tasks
Change Behind Feature Flag: No
Tech Design / Approach
NA
Documentation Changes Required: No
Unit Tests Added or Updated: No
Additional Testing Performed
Manual via building task locally and uploading in private org
Logging Added/Updated: No
Telemetry Added/Updated: No
Rollback Scenario and Process: NA
Dependency Impact Assessed and Regression Tested: Yes