Skip to content

Conversation

@rajmishra1997
Copy link
Contributor

@rajmishra1997 rajmishra1997 commented Dec 31, 2025

Context

Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items
AB#2340637
AB#2345214

Task Name

Name of the updated or newly created pipeline task.
NodeTaskRunnerInstaller

Description

Summarize the changes made in this PR clearly and concisely.
Node 24 migration for task and L0 Tests implementation

Risk Assessment (Low / Medium / High)

Assess the level of risk and provide reasoning (e.g., scope, impact, backward compatibility).


Change Behind Feature Flag (Yes / No)

Can this change be behine feature flag, if not why?
No, only tests related changes

Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.
    Design document

Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect these changes.
Yes

Additional Testing Performed

List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).
Tested in Devfabric following below steps:

  1. Updated externals.sh of agent to comment lines of node download for version 6,10,16
  2. Tested using yaml for each version [6,10,16] `trigger:
  • master

pool: Default

jobs:

  • job: InstallNodeVersions
    displayName: Install Node.js Versions
    steps:

    • task: NodeTaskRunnerInstaller@0.268.0
      displayName: 'Install Node.js 6'
      inputs:
      nodeVersion: '6' `
  1. For Node 6, set knob before agent run: AGENT_DISABLE_NODE6_TASKS="false"

Node 6:
node6

Node 10:
Node10

Node 16:
Node16


Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).
    No

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.
    No

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

Checklist

  • Related issue linked (if applicable)
  • Task version was bumped — see versioning guide
  • Verified the task behaves as expected

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@sanjuyadav24 sanjuyadav24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as Node6,10,16 all are already installed in agent node versions are not getting installed in canarytest, please share how is this tested that node installation is working as expected

@rajmishra1997
Copy link
Contributor Author

as Node6,10,16 all are already installed in agent node versions are not getting installed in canarytest, please share how is this tested that node installation is working as expected

Updated Testing details

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rajmishra1997 rajmishra1997 merged commit b84e1d2 into master Jan 8, 2026
14 checks passed
@rajmishra1997 rajmishra1997 deleted the users/rajmishra/NodeTaskRunnerInstallerFix branch January 8, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants