Merge pull request #5425 from microsoft/bugfix-npe-message

fix npe & nodes show twice in explorer.

Author: wangmingliang-ms

PluginsAndFeatures/azure-toolkit-for-intellij/azure-intellij-plugin-lib/src/main/java/com/microsoft/azure/toolkit/intellij/common/messager/IntellijAzureMessage.java

@@ -18,8 +18,8 @@
 import com.microsoft.azure.toolkit.lib.common.task.AzureTask;
 import com.microsoft.azure.toolkit.lib.common.task.AzureTaskContext;
 import lombok.Getter;
-import lombok.RequiredArgsConstructor;
 import lombok.Setter;
+import lombok.extern.java.Log;
 import org.apache.commons.lang3.ObjectUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.exception.ExceptionUtils;
@@ -35,12 +35,13 @@
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
+import java.util.logging.Level;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
 @Setter
-@RequiredArgsConstructor
+@Log
 public class IntellijAzureMessage implements IAzureMessage {
     static final Pattern URL_PATTERN = Pattern.compile("\\s+(https?|ftp)://(www\\d?|[a-zA-Z0-9]+)?.[a-zA-Z0-9-]+(:|.)([a-zA-Z0-9.]+|(\\d+)?)([/?:].*)?");
     static final String DEFAULT_MESSAGE_TITLE = "Azure";
@@ -59,6 +60,13 @@ public class IntellijAzureMessage implements IAzureMessage {
     @Getter
     private final IAzureMessage original;
 
+    public IntellijAzureMessage(@Nonnull IAzureMessage original) {
+        this.original = original;
+        if (original.getPayload() instanceof Throwable) {
+            log.log(Level.WARNING, "caught error in IntellijAzureMessager", ((Throwable) original.getPayload()));
+        }
+    }
+
     public IntellijAzureMessage(@Nonnull Type type, @Nonnull String message) {
         this(new SimpleMessage(type, message));
     }
@@ -143,7 +151,7 @@ public Boolean getBackgrounded() {
     private static String getCause(@Nonnull Throwable throwable) {
         final Throwable root = getRecognizableCause(throwable);
         if (Objects.isNull(root)) {
-            return null;
+            return ExceptionUtils.getRootCause(throwable).toString();
         }
         String cause = null;
         if (root instanceof ManagementException) {
@@ -163,7 +171,7 @@ private static Throwable getRecognizableCause(@Nonnull Throwable throwable) {
                 continue;
             }
             final String rootClassName = t.getClass().getName();
-            if (rootClassName.startsWith("com.microsoft.azure") || rootClassName.startsWith("com.azure")) {
+            if (rootClassName.startsWith("com.microsoft") || rootClassName.startsWith("com.azure")) {
                 return t;
             }
         }

PluginsAndFeatures/azure-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/springcloud/properties/SpringCloudAppPanel.java

@@ -173,7 +173,9 @@ private void setApp(@Nonnull SpringCloudApp app) {
     private void updateForm() {
         assert Objects.nonNull(app): "app is not specified";
         final String testUrl = app.entity().getTestUrl();
-        this.txtTestEndpoint.setHyperlinkText(testUrl.length() > 60 ? testUrl.substring(0, 60) + "..." : testUrl);
+        if (testUrl != null) {
+            this.txtTestEndpoint.setHyperlinkText(testUrl.length() > 60 ? testUrl.substring(0, 60) + "..." : testUrl);
+        }
         this.txtTestEndpoint.setHyperlinkTarget(testUrl);
 
         final SpringCloudSku sku = app.getCluster().entity().getSku();

Utils/azure-explorer-common/src/com/microsoft/tooling/msservices/serviceexplorer/azure/springcloud/SpringCloudNode.java

@@ -42,7 +42,7 @@ public SpringCloudNode(AzureRefreshableNode parent, SpringCloudCluster cluster)
 
     public void onAppCreatedOrRemoved(SpringCloudApp app) {
         if (this.cluster.name().equals(app.getCluster().name())) {
-            refreshItems();
+            this.load(true);
         }
     }