- 
                Notifications
    You must be signed in to change notification settings 
- Fork 177
Java Code Quality Analyzer #8584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Njeriiii
  wants to merge
  218
  commits into
  microsoft:feature-azure-sdk-plugin
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Njeriiii:azure-sdk-plugin
  
      
      
   
  
    
  
  
  
 
  
      
    base: feature-azure-sdk-plugin
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            218 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2073825
              
                hello world rule
              
              
                 881f7ba
              
                UseStorageAPIsWithLengthParameter rule
              
              
                Njeriiii f9be880
              
                UseStorageAPIsWithLengthParameter rule
              
              
                Njeriiii 7dd8cd1
              
                fully address 8/9 PR comments
              
              
                Njeriiii d07d3ce
              
                use of ServiceBusReceiverAsyncClient rule
              
              
                Njeriiii f54c668
              
                connection string rule
              
              
                Njeriiii b079589
              
                extend to include method call chain parameters
              
              
                Njeriiii 9433eb0
              
                add telemetry with Az App Insights
              
              
                Njeriiii 613b225
              
                extend telemetry to integrate background service
              
              
                Njeriiii 2fd394e
              
                addressing PR comments
              
              
                Njeriiii 5f39981
              
                removing idea files
              
              
                Njeriiii cac4126
              
                remove idea files
              
              
                Njeriiii 71902b5
              
                create readme
              
              
                Njeriiii ba056ca
              
                Update README.md
              
              
                Njeriiii 7273dce
              
                Merge pull request #8 from Njeriiii/readme-branch
              
              
                Njeriiii 61f5561
              
                Merge branch 'azure-sdk-plugin' of https://github.com/Njeriiii/azure-…
              
              
                Njeriiii ef3eb3f
              
                address comments, some refactoring, and tests
              
              
                Njeriiii 13ce22b
              
                minor edit, adding comments
              
              
                Njeriiii 180acca
              
                implement kql queries with time interval in query string rule.
              
              
                Njeriiii b179107
              
                updating README.md
              
              
                Njeriiii 09d1222
              
                [unblocks the data clearing issue] Reset the methodCounts map for eac…
              
              
                samvaity 3adda32
              
                address PR comments and add tests
              
              
                Njeriiii 50b7e6d
              
                address PR comments
              
              
                Njeriiii 6c7efb7
              
                refactor rule & add tests
              
              
                Njeriiii ece51f1
              
                updating README.md
              
              
                Njeriiii 445bdc6
              
                update to tests and README.md
              
              
                Njeriiii 2211856
              
                Update README.md
              
              
                Njeriiii dc60186
              
                minor edits
              
              
                Njeriiii 60410c2
              
                Merge pull request #2 from Njeriiii/storage-APIs-rule
              
              
                Njeriiii 2fda813
              
                implement HardcodedAPIKeysAndTokensCheck rule
              
              
                Njeriiii e2bfdd8
              
                merge with azure-sdk-plugin branch & update readme
              
              
                Njeriiii ee93aab
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii ced0ab0
              
                Merge pull request #5 from Njeriiii/reactor-rules
              
              
                Njeriiii d6f13cc
              
                integrate central json loader engine
              
              
                Njeriiii ecea9e1
              
                using block on async clients implementation
              
              
                Njeriiii b03fe93
              
                merge with azure-sdk plugin branch
              
              
                Njeriiii e1821f3
              
                using block on async clients rule implementation & testing
              
              
                Njeriiii 4b04419
              
                updating README.md
              
              
                Njeriiii 8047e43
              
                merge with azure-sdk-plugin & address PR comments
              
              
                Njeriiii 8e648f5
              
                Update README.md
              
              
                Njeriiii 42ad4ca
              
                implement dynamic client creation rule
              
              
                Njeriiii b199a93
              
                update to javadoc
              
              
                Njeriiii 13e0dd4
              
                2nd update to javadoc
              
              
                Njeriiii 43c9d69
              
                update to integrate check for azure clients
              
              
                Njeriiii aa831ba
              
                update to integrate check for azure clients
              
              
                Njeriiii c1ab3f4
              
                Merge remote-tracking branch 'origin/kql-rules' into kql-rules
              
              
                Njeriiii a1a3b77
              
                upgrade to tests
              
              
                Njeriiii 958d3e3
              
                Merge remote-tracking branch 'origin/dynamic-client-creation-rule' in…
              
              
                Njeriiii c66540a
              
                make base class to check for discouraged clients
              
              
                Njeriiii 5ce2602
              
                address PR comments
              
              
                Njeriiii d21bd9a
              
                address PR comments
              
              
                Njeriiii b838103
              
                Merge remote-tracking branch 'origin/connection-strings-rule' into co…
              
              
                Njeriiii 9e984c8
              
                small fix to ConnectionStringCheck class
              
              
                Njeriiii d9054ab
              
                update to recommendation
              
              
                Njeriiii 0239a88
              
                Merge remote-tracking branch 'origin/connection-strings-rule' into co…
              
              
                Njeriiii 1e8c39a
              
                very minor tweak to README.md
              
              
                Njeriiii 821aa75
              
                initial implementation & test for GetSyncPollerOnPollerFluxCheck
              
              
                Njeriiii b3060c7
              
                initial implementation & test for SingleOperationInLoopCheck
              
              
                Njeriiii 800c146
              
                complete implementation of SingleOperationInLoopCheck with tests
              
              
                Njeriiii 391e829
              
                update to README.md
              
              
                Njeriiii cf828cd
              
                A
              
              
                Njeriiii 33ef731
              
                update to README.md
              
              
                Njeriiii f7d0d2c
              
                complete implementation of GetSyncPollerOnPollerFluxCheck with test
              
              
                Njeriiii 5c899fe
              
                Merge branch 'azure-sdk-plugin' of https://github.com/Njeriiii/azure-…
              
              
                Njeriiii b064cb4
              
                update to README.md
              
              
                Njeriiii 4bc0d08
              
                completion of TelemetryClientProvider
              
              
                Njeriiii 40663f3
              
                merge with azure-sdk-plugin, refactored TelemetryClientProvider and c…
              
              
                Njeriiii 5b158d1
              
                completion of TelemetryClientProvider with tests
              
              
                Njeriiii 8ba32e6
              
                minor tweak to tests
              
              
                Njeriiii c51a7a8
              
                address PR comments
              
              
                Njeriiii ded49fb
              
                merge with azure-sdk-plugin-branch
              
              
                Njeriiii 0e42c14
              
                minor update
              
              
                Njeriiii 9fa65e5
              
                address PR comments
              
              
                Njeriiii 0a59e52
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 9a7c209
              
                refactor to add named class
              
              
                Njeriiii c006e1f
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii b996d1c
              
                address PR comments
              
              
                Njeriiii 5bacaad
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii d177ee4
              
                update to README.md
              
              
                Njeriiii 2f826c7
              
                addressing PR comments
              
              
                Njeriiii 055fea3
              
                modification to make rule specific to Text Analytics APIs
              
              
                Njeriiii 7513dc5
              
                integrate central json loader engine
              
              
                Njeriiii 3043e9a
              
                minor edit to javadoc
              
              
                Njeriiii be00aa5
              
                make fix to client name
              
              
                Njeriiii 54e14fa
              
                extend to service call/rest api call via az clients
              
              
                Njeriiii dfe0b56
              
                complete implementation & test for DisableAutoCompleteCheck
              
              
                Njeriiii 3ccc5f0
              
                address PR comments
              
              
                Njeriiii 946f64d
              
                Apply suggestions from code review
              
              
                Njeriiii ff557a2
              
                make changes suggested offline
              
              
                Njeriiii a20df31
              
                initial implementation of ServiceBusReceiveModeCheck
              
              
                Njeriiii 514b68e
              
                Update RuleConfig.java comments
              
              
                Njeriiii a5ae7a2
              
                update to add tests
              
              
                Njeriiii 85267c2
              
                add changes discussed offline
              
              
                Njeriiii c192a64
              
                update to README.md
              
              
                Njeriiii b5a1f67
              
                update to make RuleConfig an immutable class
              
              
                Njeriiii 7d10b76
              
                address PR comments
              
              
                Njeriiii d38529f
              
                address PR comments
              
              
                Njeriiii 169ef2f
              
                Merge pull request #16 from Njeriiii/json-config-loader-branch
              
              
                Njeriiii 1067a9f
              
                merge with azure-sdk-plugin branch & address PR comments
              
              
                Njeriiii 52930f6
              
                small Update README.md
              
              
                Njeriiii 660e31d
              
                Merge pull request #17 from Njeriiii/servicebus-receiver-and-processo…
              
              
                Njeriiii 5c32208
              
                merge with azure-sdk-plugin branch & address PR comments
              
              
                Njeriiii e72c47f
              
                update to README.md
              
              
                Njeriiii a2a533b
              
                Merge pull request #12 from Njeriiii/dynamic-client-creation-rule
              
              
                Njeriiii 6e76dba
              
                update to README.md
              
              
                Njeriiii 47fbf09
              
                merge with azure-sdk-plugin branch & address PR comments
              
              
                Njeriiii b5a8b0b
              
                Merge branch 'api-keys-and-tokens-rule' of https://github.com/Njeriii…
              
              
                Njeriiii cb4de51
              
                Merge pull request #10 from Njeriiii/api-keys-and-tokens-rule
              
              
                Njeriiii 2ebe214
              
                merging with azure-sdk-plugin branch
              
              
                Njeriiii 237a3d7
              
                Merge pull request #6 from Njeriiii/connection-strings-rule
              
              
                Njeriiii 9953e73
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii dd484f8
              
                complete implementation of ServiceBusReceiveModeCheck
              
              
                Njeriiii 1a3778b
              
                minor edit to azure-intellij-plugin-azure-sdk.xml
              
              
                Njeriiii 35a5f0b
              
                address PR comments
              
              
                Njeriiii 48fdfb1
              
                merge azure-sdk-plugin branch & address PR comments
              
              
                Njeriiii f23d2fc
              
                Update .gitignore
              
              
                Njeriiii a114475
              
                address PR comments
              
              
                Njeriiii 547e0e2
              
                merge with azure-sdk-plugin branch & address PR comments
              
              
                Njeriiii 46c5f94
              
                implement base class to check for discouraged APIs
              
              
                Njeriiii 3e898b7
              
                modify to correctly find service APIs
              
              
                Njeriiii 1cf1fd7
              
                address PR comments
              
              
                Njeriiii cd76d29
              
                merge with azure-sdk-plugin branch & address PR comments
              
              
                Njeriiii 6c05ea4
              
                update to README.md
              
              
                Njeriiii 32307d7
              
                integrate toggle telemetry UI
              
              
                Njeriiii cd92e71
              
                merge with azure-sdk-plugin-branch
              
              
                Njeriiii 66eb550
              
                Update to comment on GetSyncPollerOnPollerFluxCheck.java
              
              
                Njeriiii 4c72275
              
                Merge pull request #15 from Njeriiii/poller-functions-rule
              
              
                Njeriiii 9f22160
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 7e5066a
              
                address PR comments
              
              
                Njeriiii 4fc5ee0
              
                Merge remote-tracking branch 'origin/service-bus-receive-mode-rule' i…
              
              
                Njeriiii 539fafc
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii c71b40a
              
                address PR comments
              
              
                Njeriiii f800374
              
                address PR comments
              
              
                Njeriiii 0d79413
              
                address PR comments
              
              
                Njeriiii 2404901
              
                initial implementation of UpdateCheckpointAsyncCheck with tests
              
              
                Njeriiii a1b412e
              
                Merge pull request #18 from Njeriiii/service-bus-receive-mode-rule
              
              
                Njeriiii 2ad08ab
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 824c19e
              
                address PR comments
              
              
                Njeriiii b8b4374
              
                Merge pull request #19 from Njeriiii/chat-applications-rule
              
              
                Njeriiii 7a72525
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii c097ff3
              
                Merge remote-tracking branch 'origin/singe-operations-in-loop-rule' i…
              
              
                Njeriiii b38c8fc
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 1058230
              
                complete implementation of UpdateCheckpointAsyncCheck
              
              
                Njeriiii 2590838
              
                update to javadocs
              
              
                Njeriiii 0e4ce1b
              
                update to implementation
              
              
                Njeriiii fa1b864
              
                address PR comments
              
              
                Njeriiii f7b3dd8
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii a8b7f1d
              
                remove change diff from README.md
              
              
                Njeriiii b33a7e9
              
                remove change diff README.md
              
              
                Njeriiii 1b512ab
              
                Update README.md
              
              
                Njeriiii fcffaf0
              
                remove change diff from README.md
              
              
                Njeriiii 39a0627
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 3e7b2a9
              
                Merge pull request #7 from Njeriiii/telemetry-setup
              
              
                Njeriiii 7bc2e51
              
                syntax update to KustoQueriesWithTimeIntervalInQueryStringCheck.java
              
              
                Njeriiii f2816f9
              
                refactor antipattern message extraction in RuleConfigLoader
              
              
                Njeriiii 691b2fd
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 62e5615
              
                address PR changes
              
              
                Njeriiii e56585c
              
                remove diff from applicationInsights.json
              
              
                Njeriiii e2786e3
              
                remove diff from applicationInsights.json
              
              
                Njeriiii 58aa6f4
              
                remove diff from appinsights.json
              
              
                Njeriiii c282b2b
              
                address PR comments
              
              
                Njeriiii 8cacb67
              
                address PR comments
              
              
                Njeriiii a64bd1b
              
                Merge remote-tracking branch 'origin/kql-rules' into kql-rules
              
              
                Njeriiii 7123a17
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 89aadfd
              
                refactor to create abstract base class for 2 checkers
              
              
                Njeriiii 164f018
              
                refactor to create abstract base class for 2 checkers
              
              
                Njeriiii 1823d1c
              
                rename ruleConfigs.json for consistency
              
              
                Njeriiii 328854a
              
                implement versioning rules with tests
              
              
                Njeriiii deb4562
              
                Merge pull request #13 from Njeriiii/reactor-rules
              
              
                Njeriiii 9f3c09b
              
                update to build.gradle
              
              
                Njeriiii 8f537a2
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii d0242b9
              
                Merge pull request #14 from Njeriiii/singe-operations-in-loop-rule
              
              
                Njeriiii 2c3ad89
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii cc94d94
              
                update to README.md
              
              
                Njeriiii 7e414b2
              
                update to ruleConfigs.json
              
              
                Njeriiii 9fdc8f0
              
                update to abstract class
              
              
                Njeriiii 28e95d0
              
                update to abstract class
              
              
                Njeriiii 77561cb
              
                address PR comments
              
              
                Njeriiii 277146b
              
                implementation with test
              
              
                Njeriiii c7afa6e
              
                address PR comments
              
              
                Njeriiii c3c4b26
              
                implement rule with tests
              
              
                Njeriiii e05494b
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 5cf5e7b
              
                address PR comments
              
              
                Njeriiii 40fa7be
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 5d6c4fd
              
                Merge pull request #20 from Njeriiii/update-checkpoint-async-rule-branch
              
              
                Njeriiii b93ecee
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii bd204f5
              
                Merge pull request #9 from Njeriiii/kql-rules
              
              
                Njeriiii 02a8cf2
              
                update to implementation
              
              
                Njeriiii 36fb9d7
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 4067b53
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 3669830
              
                address PR comments
              
              
                Njeriiii dec4ca1
              
                address PR comments
              
              
                Njeriiii 6a47687
              
                Merge pull request #22 from Njeriiii/authenticating-non-azure-openai
              
              
                Njeriiii ad44fc2
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 86bfbeb
              
                complete implementation with tests
              
              
                Njeriiii af82b89
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii db499d1
              
                refactor to use mvn central data source
              
              
                Njeriiii 1bc9d32
              
                update to abstract class
              
              
                Njeriiii bfe58c3
              
                integrate caching
              
              
                Njeriiii f19f1a4
              
                address PR comments
              
              
                Njeriiii 524019f
              
                address PR comments
              
              
                Njeriiii 2673679
              
                address PR comments
              
              
                Njeriiii 48813c5
              
                address PR comments
              
              
                Njeriiii cbd4bd3
              
                remove changes from diff
              
              
                Njeriiii 6e421e4
              
                address PR comments
              
              
                Njeriiii d6a4e00
              
                address PR comments
              
              
                Njeriiii f431eb2
              
                Merge pull request #11 from Njeriiii/sync-over-async-rules
              
              
                Njeriiii 5d2cd85
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 22af5c2
              
                Merge pull request #21 from Njeriiii/upgrade-to-latest-version-branch
              
              
                Njeriiii fb74cb8
              
                bug fix to prevent null exceptions & remove isOnTheFly
              
              
                Njeriiii 2552869
              
                Merge pull request #26 from Njeriiii/reactor-rules
              
              
                Njeriiii 017b60a
              
                fix to handle an exception
              
              
                Njeriiii bce8288
              
                Merge pull request #29 from Njeriiii/kql-rules
              
              
                Njeriiii 773f261
              
                bug fix to handle exception
              
              
                Njeriiii 24138d5
              
                merge with azure-sdk-plugin branch
              
              
                Njeriiii 57b47aa
              
                Merge pull request #30 from Njeriiii/dynamic-client-creation-rule
              
              
                Njeriiii 6386714
              
                small edit
              
              
                Njeriiii 5a68cff
              
                Merge pull request #31 from Njeriiii/kql-rules
              
              
                Njeriiii File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            51 changes: 0 additions & 51 deletions
          
          51 
        
  PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/Project.xml
  
  
      
      
   
        
      
      
    This file was deleted.
      
      Oops, something went wrong.
      
    
  
        
          
          
            5 changes: 0 additions & 5 deletions
          
          5 
        
  PluginsAndFeatures/azure-toolkit-for-intellij/.idea/codeStyles/codeStyleConfig.xml
  
  
      
      
   
        
      
      
    This file was deleted.
      
      Oops, something went wrong.
      
    
  
        
          
          
            6 changes: 0 additions & 6 deletions
          
          6 
        
  PluginsAndFeatures/azure-toolkit-for-intellij/.idea/copyright/Microsoft.xml
  
  
      
      
   
        
      
      
    This file was deleted.
      
      Oops, something went wrong.
      
    
  
        
          
          
            16 changes: 0 additions & 16 deletions
          
          16 
        
  PluginsAndFeatures/azure-toolkit-for-intellij/.idea/findbugs-idea.xml
  
  
      
      
   
        
      
      
    This file was deleted.
      
      Oops, something went wrong.
      
    
  
        
          
          
            53 changes: 0 additions & 53 deletions
          
          53 
        
  PluginsAndFeatures/azure-toolkit-for-intellij/.idea/gradle.xml
  
  
      
      
   
        
      
      
    This file was deleted.
      
      Oops, something went wrong.
      
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't ignore this file.