Skip to content

Update libusbmuxd to 2.1.0 #10905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update libusbmuxd to 2.1.0 #10905

wants to merge 1 commit into from

Conversation

@kevin-b-lockwood
Copy link
Contributor

@kevin-b-lockwood kevin-b-lockwood commented Oct 31, 2024 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Upgrade required for libimobiledevice upgrade.

Requires #10884, #10898

Build/Dependency Information

Please build the following packages with libusbmuxd:
libimobiledevice-glue

Change Log
  • Upgrade libplist to 2.6.0
  • Add libimobiledevice-glue
  • Upgrade libplist to 2.6.0
  • Upgrade libuxbmuxd to 2.1.0-1
Does this affect the toolchain?

NO

Test Methodology
  • Local build

@kevin-b-lockwood kevin-b-lockwood requested review from a team as code owners October 31, 2024 22:47
@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/libusbmuxd-2.1.0-1 branch from 33f4026 to e6f2af1 Compare October 31, 2024 23:01
@reubeno reubeno added the specs-extended PR to fix SPECS-EXTENDED label Nov 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 9, 2025
@0xba1a 0xba1a closed this Mar 7, 2025
@0xba1a 0xba1a reopened this Mar 7, 2025
@0xba1a
Copy link
Contributor

0xba1a commented Mar 7, 2025

@kevin-b-lockwood Please update licenses file

0xba1a
0xba1a requested changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@0xba1a 0xba1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for licenses.json file update for newly added package

@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/libusbmuxd-2.1.0-1 branch from e6f2af1 to 1c9132b Compare March 7, 2025 21:13
@kevin-b-lockwood kevin-b-lockwood requested a review from 0xba1a March 7, 2025 21:14
kgodara912
kgodara912 reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for next stage: buddy build pipeline.

@kevin-b-lockwood kevin-b-lockwood mentioned this pull request Apr 24, 2025
Open
12 tasks
@kgodara912
Copy link
Contributor

You already have a dedicated PR: #10898 for adding libimobiledevice-glue to the EXTENDED-SPECS, could you please remove that from this PR and resolve merge conflict. Once that PR is merged, we will merge this.

@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/libusbmuxd-2.1.0-1 branch from 1c9132b to f53f2d8 Compare June 9, 2025 19:19
@kevin-b-lockwood
Copy link
Contributor Author

Normally I don't like to force push after a patchset has been reviewed, but I felt it was the best way to drop the duplicate commits from #10898. Should be good to go.

@sandeepkarambelkar
Copy link
Contributor

Waiting for work on #10898 to be closed.

@sandeepkarambelkar
Copy link
Contributor

@kevin-b-lockwood, Can you rebase and focus on this now since #10898 is merged now.

@v-aaditya
Copy link
Contributor

A new PR #14876 has been created for upgrading libusbmuxd version to 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgodara912 kgodara912 kgodara912 left review comments

@0xba1a 0xba1a Awaiting requested review from 0xba1a

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kevin-b-lockwood @0xba1a @kgodara912 @sandeepkarambelkar @v-aaditya @reubeno