Skip to content

Conversation

@Kanishk-Bansal
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal commented Sep 18, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner September 18, 2025 03:47
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Sep 18, 2025
Provides: python%{majmin_nodots} = %{version}-%{release}
%if %{with_check}

%if 0%{?with_check}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rpmspec was not able to parse the spec
image

  • Original: %if %{with_check}

    • This condition is true if the macro with_check is defined and non-zero. If with_check is not defined, this can produce an error like it is creating right now when we are doing rpmspec parse.
  • Changed to: %if 0%{?with_check}

    • 0%{?with_check} safely expands to 0 if with_check is not defined (so, false), or to the value of with_check if it is defined (still works as before if set).
    • The ? in %{?with_check} means "use the value if defined, otherwise nothing."
    • Prefixing with 0 ensures the macro always expands to a valid number (0/1), avoiding errors if undefined.

@Kanishk-Bansal
Copy link
Contributor Author

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Kanishk Bansal <[email protected]>
@Kanishk-Bansal Kanishk-Bansal force-pushed the kanbansal/python/2.0/CVE-2025-8194 branch from 0d41e22 to 7dcb78c Compare September 18, 2025 06:20
@Kanishk-Bansal
Copy link
Contributor Author

the patch applies cleanly w.r.t upstream patch python/cpython#137645
No modification was needed.

@Kanishk-Bansal
Copy link
Contributor Author

vitess, rpm-ostree, prometheus-process-exporter, moby-runc, libguestfs, pygobject3 are known failures.
This is not due to regression by this patch

Copy link
Contributor

@realsdx realsdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Patch applies cleanly
Image
  • Security tag exists
  • Release bump & Changelog
  • Buddy Build
  • No new ptest regression
    Signed-off-by: @realsdx

@realsdx realsdx added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Sep 18, 2025
@PawelWMS PawelWMS merged commit b174f1e into fasttrack/2.0 Oct 3, 2025
16 of 20 checks passed
@PawelWMS PawelWMS deleted the kanbansal/python/2.0/CVE-2025-8194 branch October 3, 2025 19:35
CBL-Mariner-Bot pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Kanishk Bansal <[email protected]>
Co-authored-by: Kanishk Bansal <[email protected]>
(cherry picked from commit b174f1e)
@CBL-Mariner-Bot
Copy link
Collaborator

aaruag pushed a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Kanishk Bansal <[email protected]>
Co-authored-by: Kanishk Bansal <[email protected]>
(cherry picked from commit b174f1e)
aaruag pushed a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Kanishk Bansal <[email protected]>
Co-authored-by: Kanishk Bansal <[email protected]>
(cherry picked from commit b174f1e)
aaruag pushed a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Kanishk Bansal <[email protected]>
Co-authored-by: Kanishk Bansal <[email protected]>
(cherry picked from commit b174f1e)
aaruag pushed a commit that referenced this pull request Oct 16, 2025
Signed-off-by: Kanishk Bansal <[email protected]>
Co-authored-by: Kanishk Bansal <[email protected]>
(cherry picked from commit b174f1e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants