[bf-lu] validate empty phrase list (#972)

* add empty phraseList validation in luisValidator

* adjust error msg

Author: feich-ms

packages/lu/src/parser/lufile/parseFileContents.js

@@ -1422,7 +1422,7 @@ const handlePhraseList = function(parsedContent, entityName, entityType, entityR
                 let errorMsg = `Phrase list entity ${entityName} has invalid role definition with roles = ${entityRoles.join(', ')}. Roles are not supported for Phrase Lists`;
                 let error = BuildDiagnostic({
                     message: errorMsg,
-                    context: currentLine
+                    context: range
                 })
 
                 throw (new exception(retCode.errorCode.INVALID_INPUT, error.toString(), [error]));
@@ -1448,7 +1448,7 @@ const handlePhraseList = function(parsedContent, entityName, entityType, entityR
     let pLValues = [];
     for (const phraseListValues of valuesList) {
         phraseListValues.split(/[,;]/g).map(item => item.trim()).forEach(item => pLValues.push(item));
-   }
+    }
 
     let pLEntityExists = parsedContent.LUISJsonStructure.model_features.find(item => item.name == entityName);
     if (pLEntityExists) {

packages/lu/src/parser/luis/luisValidator.js

@@ -120,6 +120,14 @@ const validateBoundaries = function(luisJSON) {
         }
     })
 
+    // phrase list - phraselist cannot be null or empty. 
+    phraseLists.forEach(item => {
+        console.log(item.words)
+        if (item.words === undefined || item.words.trim() === '' || item.words.split(',').length === 0) {
+            validationError(retCode.errorCode.BOUNDARY_MINMUM_PHRASE_LIMIT, `0 phrases found in phrase list: ${item.name}. Empty phrase list is not allowed.`)
+        }
+    })
+
     // Roles - 10 roles per entity
     let totalRoles = 0;
     ["prebuiltEntities", "patternAnyEntities", "regex_entities", "closedLists", "composites", "entities"].forEach(scope => {

packages/lu/src/parser/utils/enums/CLI-errors.js

@@ -49,7 +49,8 @@ module.exports = {
         BOUNDARY_FEATURE_PER_MODEL: 517,
         BOUNDARY_PARENT_ENTITY_LIMIT:518,
         BOUNDARY_TOTAL_ENTITIES_AND_ROLES:519,
-        BOUNDARY_TOTAL_CLOSED_LISTS:520
+        BOUNDARY_TOTAL_CLOSED_LISTS:520,
+        BOUNDARY_MINMUM_PHRASE_LIMIT:521
     },
     boundaryLimits: {
         MAX_NUM_INTENTS:                    500,

packages/lu/test/parser/lufile/luis.boundary.test.js

@@ -201,6 +201,16 @@ describe('Validations for LU content (based on LUIS boundaries)', function () {
             })
     })
 
+    it (`At Least one phrase in any phrase list`, function(done) {
+        LuisBuilder.fromLUAsync(new Array(new luObj(getMaxPhraseLists(1, 0), 'stdin', true)))
+            .then(res => done(res))
+            .catch(err => {
+                assert.equal(err.errCode, retCode.errorCode.BOUNDARY_MINMUM_PHRASE_LIMIT);
+                assert(err.text.includes(`0 phrases found in phrase list: PL0. Empty phrase list is not allowed.`));
+                done();
+            })
+    })
+
 })
 
 const getMaxListEntity = function() {