Changed the use of FrameworkElement.Tag to RadixButton.Label

[Hexer611]

Fixes

• It was recommended to use internal logic instead of Tag usage for codebase quality:
• Calculator should not use FrameworkElement.Tag as it can be easily overwritten by internal control logic. #56
• This pull request is aimed to help with that.

Description of the changes:

• Added a Dependency property to RadixButton.cs that is called Label. I chose the name of the variable based on the Radix button style used in CalculatorProgrammerOperators.xaml. TextBlock x:Name="LabelPresenter" was used in there to display the label text.
• Changed en-US/Resources.resw file to keep the variable names aligned, from "Tag" to "Label".
• Changed "CalculatorProgrammerOperators.xaml" file to use new Label variable and new resource string. I believe it was necessary to change "TargetType" of "ProgModeRadioButtonStyle" and the templates inside to be able to use Label variable.

Note: I honestly am not sure if changing "TargetType="RadioButton"" to TargetType="controls:RadixButton" is completely correct. It works when compiled, and i didn't see any problems. Since RadixButton is inherited from RadioButton and this style was only used for RadixButtons, this change should also be fine.

How changes were validated:

• The number of changes were limited, so i only validated the changes by hand. I tried compiling the Calculator with each change seperately and observed the changes.

Lastly

• The issue suggests the fix for other places for the use of FrameworkElement.Tag . Since this is my first pull request i wanted to know if I'm on the right path. I'll try to find a solution for the other ones too.

[Hexer611]

@microsoft-github-policy-service agree