Skip to content

API Change to customize VM spec (including custom GPU specifications) #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2sjha wants to merge 5 commits into from
Closed

API Change to customize VM spec (including custom GPU specifications) #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
918b5bd
add custom GPU in API
Nov 10, 2025
a354a20
update custom config struct
Nov 12, 2025
d91fe7c
update moc and moc-sdk tags
Nov 13, 2025
9fd8f9c
generated API changes
Nov 13, 2025
35fc43b
revert go modules
Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/v1beta1/azurestackhcimachine_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ type AzureStackHCIMachineSpec struct {

GpuCount int32 `json:"gpuCount,omitempty"`

// VM cpu/memory/GPU details when VM size type is custom
// +optional
CustomSize VirtualMachineCustomSize `json:"customSize,omitempty"`

// AllocatePublicIP allows the ability to create dynamic public ips for machines where this value is true.
// +optional
AllocatePublicIP bool `json:"allocatePublicIP,omitempty"`
Expand Down
4 changes: 4 additions & 0 deletions api/v1beta1/azurestackhcivirtualmachine_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ type AzureStackHCIVirtualMachineSpec struct {
// if not specified, it's a vm without gpu
GpuCount int32 `json:"gpuCount,omitempty"`

// VM cpu/memory/GPU details when VM size type is custom
// +optional
CustomSize VirtualMachineCustomSize `json:"customSize,omitempty"`

// come from the cluster scope for machine and lb controller creation path
ResourceGroup string `json:"resourceGroup"`
VnetName string `json:"vnetName"`
Expand Down
26 changes: 26 additions & 0 deletions api/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,32 @@ type AvailabilityZone struct {
Enabled *bool `json:"enabled,omitempty"`
}

// VirtualMachineCustomSize specifies cpu/memory/gpu information for custom VMSize types.
type VirtualMachineCustomSize struct {
CpuCount *int32 `json:"cpucount,omitempty"`
MemoryMB *int32 `json:"memorymb,omitempty"`
Assignment *GpuAssignment `json:"assignment,omitempty"`
PartitionSizeMB *uint64 `json:"partitionSizeMB,omitempty"`
GpuName *string `json:"gpuName,omitempty"`
GpuDriver *string `json:"gpuDriver,omitempty"`
MMIORegion *GpuMemoryMappedIORegion `json:"mmioRegion,omitempty"`
}

type GpuAssignment string

// possible values of gpu assignment
const (
GpuDDA GpuAssignment = "GpuDDA"
GpuP GpuAssignment = "GpuP"
GpuPV GpuAssignment = "GpuPV"
GpuDefault GpuAssignment = "GpuDefault"
)

type GpuMemoryMappedIORegion struct {
Low *uint64 `json:"low,omitempty"`
High *uint64 `json:"high,omitempty"`
}

// VMIdentity defines the identity of the virtual machine, if configured.
type VMIdentity string

Expand Down
77 changes: 77 additions & 0 deletions api/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_azurestackhcimachines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,34 @@ spec:
id:
type: string
type: object
customSize:
description: VM cpu/memory/GPU details when VM size type is custom
properties:
assignment:
type: string
cpucount:
format: int32
type: integer
gpuDriver:
type: string
gpuName:
type: string
memorymb:
format: int32
type: integer
mmioRegion:
properties:
high:
format: int64
type: integer
low:
format: int64
type: integer
type: object
partitionSizeMB:
format: int64
type: integer
type: object
gpuCount:
format: int32
type: integer
Expand Down
29 changes: 29 additions & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_azurestackhcimachinetemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,35 @@ spec:
id:
type: string
type: object
customSize:
description: VM cpu/memory/GPU details when VM size type is
custom
properties:
assignment:
type: string
cpucount:
format: int32
type: integer
gpuDriver:
type: string
gpuName:
type: string
memorymb:
format: int32
type: integer
mmioRegion:
properties:
high:
format: int64
type: integer
low:
format: int64
type: integer
type: object
partitionSizeMB:
format: int64
type: integer
type: object
gpuCount:
format: int32
type: integer
Expand Down
28 changes: 28 additions & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_azurestackhcivirtualmachines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,34 @@ spec:
type: string
clusterName:
type: string
customSize:
description: VM cpu/memory/GPU details when VM size type is custom
properties:
assignment:
type: string
cpucount:
format: int32
type: integer
gpuDriver:
type: string
gpuName:
type: string
memorymb:
format: int32
type: integer
mmioRegion:
properties:
high:
format: int64
type: integer
low:
format: int64
type: integer
type: object
partitionSizeMB:
format: int64
type: integer
type: object
gpuCount:
description: if not specified, it's a vm without gpu
format: int32
Expand Down