Skip to content

Commit 242a49e

Browse files
geoffw0mchammer01
andauthored
Apply suggestions from code review
Co-authored-by: mc <[email protected]>
1 parent 46fc1fd commit 242a49e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

swift/ql/src/change-notes/2023-08-23-incomplete-hostname-regex.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
category: newQuery
33
---
44

5-
* Added new query "Incomplete regular expression for hostnames" (`swift/incomplete-hostname-regexp`). This query finds regular expressions matching a URL or hostname that might match more hostnames than expected.
5+
* Added new query "Incomplete regular expression for hostnames" (`swift/incomplete-hostname-regexp`). This query finds regular expressions matching a URL or hostname that may match more hostnames than expected.

swift/ql/src/queries/Security/CWE-020/IncompleteHostnameRegex.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050

5151
<p>
5252

53-
The check is however easy to bypass because the unescaped
53+
The check is, however, easy to bypass because the unescaped
5454
<code>.</code> allows for any character before
5555
<code>example.com</code>, effectively allowing the redirect to go to
5656
an attacker-controlled domain such as <code>wwwXexample.com</code>.
@@ -68,7 +68,7 @@
6868
</example>
6969

7070
<references>
71-
<li>OWASP: <a href="https://www.owasp.org/index.php/Server_Side_Request_Forgery">Server Side Request Forgery</a></li>
72-
<li>OWASP: <a href="https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html">Unvalidated Redirects and Forwards Cheat Sheet</a></li>
71+
<li>OWASP: <a href="https://www.owasp.org/index.php/Server_Side_Request_Forgery">Server Side Request Forgery</a>.</li>
72+
<li>OWASP: <a href="https://cheatsheetseries.owasp.org/cheatsheets/Unvalidated_Redirects_and_Forwards_Cheat_Sheet.html">Unvalidated Redirects and Forwards Cheat Sheet</a>.</li>
7373
</references>
7474
</qhelp>

0 commit comments

Comments
 (0)