Skip to content

Commit d9da944

Browse files
committed
JS: Rephrase TODO
This is useful info, but not something that can be fixed locally in this query, so a TODO comment isn't helping
1 parent 3def8ec commit d9da944

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeJQueryPluginQuery.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ import UnsafeJQueryPluginCustomizations::UnsafeJQueryPlugin
1111
* A taint-tracking configuration for reasoning about XSS in unsafe jQuery plugins.
1212
*/
1313
module UnsafeJQueryPluginConfig implements DataFlow::ConfigSig {
14-
// TODO: PropertyPresenceSanitizer should not block values in a content.
14+
// Note: This query currently misses some results due to two issues:
15+
// - PropertyPresenceSanitizer blocks values in a content
16+
// - localFieldStep has been omitted for performance reaons
1517
predicate isSource(DataFlow::Node source) { source instanceof Source }
1618

1719
predicate isSink(DataFlow::Node sink) { sink instanceof Sink }

0 commit comments

Comments
 (0)