Skip to content

Commit e120e84

Browse files
committed
Swift: Delete TODOs (move to issues).
1 parent bbe5f5e commit e120e84

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowDispatch.qll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,6 @@ class PropertyObserverCall extends DataFlowCall, TPropertyObserverCall {
215215
i = -1 and
216216
result = observer.getBase()
217217
or
218-
// TODO: This is correct for `willSet` (which takes a `newValue` parameter),
219-
// but for `didSet` (which takes an `oldValue` parameter) we need an rvalue
220-
// for `getBase()`.
221218
i = 0 and
222219
result = observer.getSource()
223220
}

swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,6 @@ private module ArgumentNodes {
433433
ObserverArgumentNode() {
434434
observer.getBase() = this.getCfgNode()
435435
or
436-
// TODO: This should be an rvalue representing the `getBase` when
437-
// `observer` a `didSet` observer.
438436
observer.getSource() = this.getCfgNode()
439437
}
440438

@@ -444,7 +442,6 @@ private module ArgumentNodes {
444442
pos = TThisArgument() and
445443
observer.getBase() = this.getCfgNode()
446444
or
447-
// TODO: See the comment above for `didSet` observers.
448445
pos.(PositionalArgumentPosition).getIndex() = 0 and
449446
observer.getSource() = this.getCfgNode()
450447
)

0 commit comments

Comments
 (0)