refactor: make detector implementation details internal (#1694)

* Make data model/contract classes internal in Detectors project

Change public to internal for deserialization model classes that are
implementation details across multiple detector ecosystems: conan,
pnpm, swiftpm, vcpkg, rust (CargoLock, CargoToml, CargoSbom), poetry,
yarn (Berry contracts, TypeConverter), npm (converters), pip
(PipReportGraphNode, PythonVersion), and uv model classes.

Types exposed through public interfaces/APIs are left public to
maintain build compatibility.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: make detector implementation details internal

Make ~80 classes internal in the Detectors project:

- Data model/contract classes (ConanLock, PnpmYaml variants, PoetryLock,
  SwiftResolvedFile, VcpkgSBOM, CargoToml/Sbom, YarnBerry types, npm
  converters, PipReportGraphNode, PythonVersion, UvLock/Package, etc.)
- Parser implementations (GoModParser, YarnLockParser, RustCargoLockParser,
  MavenStyleDependencyGraphParserService, PnpmParsingUtilities, etc.)
- Concrete detector classes (NpmComponentDetector, NuGetComponentDetector,
  GoComponentDetector, RustSbomDetector, etc.)
- Linux scanner internals (LinuxScanner, all component factories, filters)
- Service implementations (MavenCommandService, PythonCommandService,
  PyPiClient, PipCommandService, YarnLockFileFactory, etc.)

Kept public (used by downstream consumers):
- All interfaces (IComponentDetector, IMavenCommandService, etc.)
- MvnCliComponentDetector, MavenWithFallbackDetector (used in is-checks)
- PipComponentDetector, SimplePipComponentDetector, PipReportComponentDetector
  (mocked in tests by component-detection-internal)

Updated test classes to work with internal types via InternalsVisibleTo.

Part of #455

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: JamieMagee

src/Microsoft.ComponentDetection.Detectors/Microsoft.ComponentDetection.Detectors.csproj

@@ -2,8 +2,10 @@
 
     <ItemGroup>
         <InternalsVisibleTo Include="Microsoft.ComponentDetection.Orchestrator" />
+        <InternalsVisibleTo Include="Microsoft.ComponentDetection.Orchestrator.Tests" />
         <InternalsVisibleTo Include="Microsoft.ComponentDetection.Detectors.Tests" />
         <InternalsVisibleTo Include="Microsoft.ComponentDetection.TestsUtilities" />
+        <InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7" />
     </ItemGroup>
 
     <ItemGroup>

src/Microsoft.ComponentDetection.Detectors/cocoapods/PodComponentDetector.cs

@@ -16,7 +16,7 @@ namespace Microsoft.ComponentDetection.Detectors.CocoaPods;
 using YamlDotNet.Core.Events;
 using YamlDotNet.Serialization;
 
-public class PodComponentDetector : FileComponentDetector
+internal class PodComponentDetector : FileComponentDetector
 {
     public PodComponentDetector(
         IComponentStreamEnumerableFactory componentStreamEnumerableFactory,

src/Microsoft.ComponentDetection.Detectors/conan/ConanLockComponentDetector.cs

@@ -13,7 +13,7 @@ namespace Microsoft.ComponentDetection.Detectors.Conan;
 using Microsoft.ComponentDetection.Detectors.Conan.Contracts;
 using Microsoft.Extensions.Logging;
 
-public class ConanLockComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
+internal class ConanLockComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
 {
     public ConanLockComponentDetector(
         IComponentStreamEnumerableFactory componentStreamEnumerableFactory,

src/Microsoft.ComponentDetection.Detectors/conan/Contracts/ConanLock.cs

@@ -3,7 +3,7 @@ namespace Microsoft.ComponentDetection.Detectors.Conan.Contracts;
 
 using System.Text.Json.Serialization;
 
-public class ConanLock
+internal class ConanLock
 {
     [JsonPropertyName("version")]
     public string Version { get; set; }

src/Microsoft.ComponentDetection.Detectors/conan/Contracts/ConanLockGraph.cs

@@ -4,7 +4,7 @@ namespace Microsoft.ComponentDetection.Detectors.Conan.Contracts;
 using System.Collections.Generic;
 using System.Text.Json.Serialization;
 
-public class ConanLockGraph
+internal class ConanLockGraph
 {
     [JsonPropertyName("revisions_enabled")]
     public bool RevisionsEnabled { get; set; }

src/Microsoft.ComponentDetection.Detectors/conan/Contracts/ConanLockNode.cs

@@ -6,7 +6,7 @@ namespace Microsoft.ComponentDetection.Detectors.Conan.Contracts;
 using System.Text.Json.Serialization;
 using Microsoft.ComponentDetection.Contracts.TypedComponent;
 
-public class ConanLockNode
+internal class ConanLockNode
 {
     [JsonPropertyName("context")]
     public string Context { get; set; }

src/Microsoft.ComponentDetection.Detectors/conda/CondaLockComponentDetector.cs

@@ -14,7 +14,7 @@ namespace Microsoft.ComponentDetection.Detectors.Poetry;
 using Microsoft.Extensions.Logging;
 using YamlDotNet.Serialization;
 
-public class CondaLockComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
+internal class CondaLockComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
 {
     public CondaLockComponentDetector(
         IComponentStreamEnumerableFactory componentStreamEnumerableFactory,

src/Microsoft.ComponentDetection.Detectors/dockerfile/DockerfileComponentDetector.cs

@@ -15,7 +15,7 @@ namespace Microsoft.ComponentDetection.Detectors.Dockerfile;
 using Microsoft.Extensions.Logging;
 using Valleysoft.DockerfileModel;
 
-public class DockerfileComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
+internal class DockerfileComponentDetector : FileComponentDetector, IDefaultOffComponentDetector
 {
     private readonly ICommandLineInvocationService commandLineInvocationService;
     private readonly IEnvironmentVariableService envVarService;

src/Microsoft.ComponentDetection.Detectors/dotnet/DotNetComponentDetector.cs

@@ -16,7 +16,7 @@ namespace Microsoft.ComponentDetection.Detectors.DotNet;
 using Microsoft.ComponentDetection.Contracts.TypedComponent;
 using Microsoft.Extensions.Logging;
 
-public class DotNetComponentDetector : FileComponentDetector
+internal class DotNetComponentDetector : FileComponentDetector
 {
     private const string GlobalJsonFileName = "global.json";
     private readonly ICommandLineInvocationService commandLineInvocationService;

src/Microsoft.ComponentDetection.Detectors/go/GoComponentDetector.cs

@@ -16,7 +16,7 @@ namespace Microsoft.ComponentDetection.Detectors.Go;
 using Microsoft.ComponentDetection.Contracts.TypedComponent;
 using Microsoft.Extensions.Logging;
 
-public class GoComponentDetector : FileComponentDetector
+internal class GoComponentDetector : FileComponentDetector
 {
     private readonly HashSet<string> projectRoots = [];