Skip to content

Refactor NpmLockfile3Detector and tests to improve dependency recordi…

4b9e0d0
Select commit
Loading
Failed to load commit list.
Open

Fixes nested dependency detection in NpmLockfile3Detector and applies the engines array fix that was missing from PR #1400. #1606

Refactor NpmLockfile3Detector and tests to improve dependency recordi…
4b9e0d0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2026 in 0s

90.2% (+0.1%) compared to 601ebcd

View this Pull Request on Codecov

90.2% (+0.1%) compared to 601ebcd

Details

Codecov Report

❌ Patch coverage is 95.59939% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.2%. Comparing base (601ebcd) to head (4b9e0d0).

Files with missing lines Patch % Lines
...entDetection.Detectors/npm/NpmLockfile3Detector.cs 80.0% 12 Missing and 9 partials ⚠️
...onentDetection.Detectors.Tests/NpmTestUtilities.cs 90.2% 0 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1606     +/-   ##
=======================================
+ Coverage   90.0%   90.2%   +0.1%     
=======================================
  Files        437     437             
  Lines      37181   37777    +596     
  Branches    2306    2332     +26     
=======================================
+ Hits       33499   34082    +583     
+ Misses      3210    3208      -2     
- Partials     472     487     +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.