Skip to content

Conversation

@zhenghao104
Copy link
Contributor

@zhenghao104 zhenghao104 commented Jan 14, 2026

Reverts #1600 to unblock component detection rollout

@zhenghao104 zhenghao104 requested a review from a team as a code owner January 14, 2026 20:52
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.1%. Comparing base (a5fe5ed) to head (dd489e1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1613     +/-   ##
=======================================
- Coverage   90.1%   90.1%   -0.1%     
=======================================
  Files        435     435             
  Lines      37461   37357    -104     
  Branches    2315    2309      -6     
=======================================
- Hits       33769   33662    -107     
- Misses      3216    3220      +4     
+ Partials     476     475      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts PR #1600, which added an image scope scanning option to the Linux detector. The revert removes the configurable scanning scope feature to unblock the component detection cloudbuild rollout.

Changes:

  • Removed the LinuxScannerScope enum and all related scope parameter handling
  • Restored hardcoded --scope all-layers behavior in the Linux scanner
  • Removed tests and documentation for the Linux.ImageScanScope detector argument

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Microsoft.ComponentDetection.Detectors/linux/LinuxScannerScope.cs Deleted the LinuxScannerScope enum file
src/Microsoft.ComponentDetection.Detectors/linux/ILinuxScanner.cs Removed scope parameter from interface method signature
src/Microsoft.ComponentDetection.Detectors/linux/LinuxScanner.cs Removed scope parameter handling and restored hardcoded all-layers scope
src/Microsoft.ComponentDetection.Detectors/linux/LinuxContainerDetector.cs Removed GetScanScope() method and scope parameter passing
test/Microsoft.ComponentDetection.Detectors.Tests/LinuxScannerTests.cs Removed scope-related test cases and unused using System; import
test/Microsoft.ComponentDetection.Detectors.Tests/LinuxContainerDetectorTests.cs Removed scope parameter from mock setups and deleted scope-related tests
docs/detectors/linux.md Removed documentation for the Linux.ImageScanScope detector argument

@zhenghao104 zhenghao104 enabled auto-merge (squash) January 14, 2026 20:58
@zhenghao104 zhenghao104 merged commit 6cdaa20 into main Jan 14, 2026
33 checks passed
@zhenghao104 zhenghao104 deleted the revert-1600-users/jasonpaulos/add-linux-syft-scope-param branch January 14, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants