-
Notifications
You must be signed in to change notification settings - Fork 114
Revert "Add image scope scanning option to the Linux detector" #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add image scope scanning option to the Linux detector" #1613
Conversation
This reverts commit c6846ef.
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
=======================================
- Coverage 90.1% 90.1% -0.1%
=======================================
Files 435 435
Lines 37461 37357 -104
Branches 2315 2309 -6
=======================================
- Hits 33769 33662 -107
- Misses 3216 3220 +4
+ Partials 476 475 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts PR #1600, which added an image scope scanning option to the Linux detector. The revert removes the configurable scanning scope feature to unblock the component detection cloudbuild rollout.
Changes:
- Removed the
LinuxScannerScopeenum and all related scope parameter handling - Restored hardcoded
--scope all-layersbehavior in the Linux scanner - Removed tests and documentation for the
Linux.ImageScanScopedetector argument
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.ComponentDetection.Detectors/linux/LinuxScannerScope.cs |
Deleted the LinuxScannerScope enum file |
src/Microsoft.ComponentDetection.Detectors/linux/ILinuxScanner.cs |
Removed scope parameter from interface method signature |
src/Microsoft.ComponentDetection.Detectors/linux/LinuxScanner.cs |
Removed scope parameter handling and restored hardcoded all-layers scope |
src/Microsoft.ComponentDetection.Detectors/linux/LinuxContainerDetector.cs |
Removed GetScanScope() method and scope parameter passing |
test/Microsoft.ComponentDetection.Detectors.Tests/LinuxScannerTests.cs |
Removed scope-related test cases and unused using System; import |
test/Microsoft.ComponentDetection.Detectors.Tests/LinuxContainerDetectorTests.cs |
Removed scope parameter from mock setups and deleted scope-related tests |
docs/detectors/linux.md |
Removed documentation for the Linux.ImageScanScope detector argument |
Reverts #1600 to unblock component detection rollout