Skip to content

Contributing back patches to 1DS #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Contributing back patches to 1DS #1266

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3210885
Contributing back patch
lakroy Apr 22, 2024
7b1826d
Applying ecs-proxy-fix.patch
lakroy Apr 22, 2024
85aea58
Merge branch 'main' into lakshmiroy/patch
mkoscumb Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/include/public/IECSClient.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "ILogger.hpp"

#include <string>
#include <unordered_set>
#include <vector>
#include <map>

Expand Down Expand Up @@ -51,6 +52,10 @@ namespace Microsoft {

// [optional] enabled ECS telemetry
bool enableECSClientTelemetry = false;

// [optional] Mandatory agents list. If not present in response, the payload
// is determined as bad
std::unordered_set<std::string> mandatoryAgents;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you miss adding any file, as mandatoryAgents is not used anywhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be used in the EXPCommonClient.cpp file in this PR - Pull 230 - Contributing back patches to 1DS modules. I think this PR will have to be merged first before we merged the private one.

};

/// <summary>
Expand Down