Skip to content

Remove ODWReachability and iOS 11 macOS 10.14 code with EOL for those platforms #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

denny-msft
Copy link

Started investigating the crash from #1370 and realized that ODWReachability should only be applicable for platforms below iOS 11 and macOS 10.14. However, a crash stack from an iOS 18 device clearly shows these classes being deallocated.

-[ODWReachability stopNotifier] ODWReachability.m:367
-[ODWReachability dealloc] ODWReachability.m:265
Microsoft::Applications::Events::PlatformAbstraction::NetworkInformation::~NetworkInformation() NetworkInformationImpl.mm:102

Seems like there was a bug where these reachability classes were being initialized without guarded availability checks (see NetworkInformation::SetupNetDetect:108) when they should only be used for lower platforms.

Regardless, given the EOL of these versions, this PR remove references to ODWReachability and fixes the crash.

Testing

Verified with build-ios.sh.

@denny-msft denny-msft requested a review from a team as a code owner August 13, 2025 00:55
@denny-msft denny-msft added bug Something isn't working iOS iOS related issue labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS iOS related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant