Update room version to 2.8.4 #1394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition bump gradle and AGP version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Android Room library from version 2.4.3 to 2.8.4 to fix compatibility issues with modern Android applications. The main change addresses Room's requirement that database queries must not run on the main thread, particularly in constructors.
Key Changes:
- Refactored
OfflineRoomconstructor to remove PRAGMA queries and implement lazy initialization of page size - Updated build infrastructure: Gradle 7.5 → 8.5, AGP 7.3.1 → 8.2.2, minimum SDK 19 → 23
- Simplified native library dependencies by linking maesdk directly via CMake subdirectory
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/OfflineRoom.java | Core fix: moved database queries from constructor to lazy-loaded initPageSize() method; improved field encapsulation |
| lib/android_build/maesdk/build.gradle | Updated Room dependency to 2.8.4 and test dependencies; added Kotlin generation flag |
| lib/android_build/build.gradle | Bumped Android Gradle Plugin from 7.3.1 to 8.2.2 |
| lib/android_build/tools.gradle | Updated compile/target SDK from 32/31 to 34/34, min SDK from 19 to 23 |
| lib/android_build/gradle/wrapper/gradle-wrapper.properties | Updated Gradle wrapper from 7.5 to 8.5 |
| lib/android_build/gradlew | Updated Gradle wrapper scripts with newer template |
| lib/android_build/gradlew.bat | Updated Windows Gradle wrapper script |
| lib/android_build/gradle/wrapper/gradle-wrapper.jar | Binary update for Gradle 8.5 wrapper |
| tools/build-android-aar.sh | New script for building Android AAR files locally with NDK support |
| tests/unittests/PalTests.cpp | Added Android-specific path handling for filesystem tests |
| lib/android_build/app/src/main/cpp/CMakeLists.txt | Changed from importing prebuilt library to building maesdk via subdirectory |
| lib/android_build/app/src/main/java/com/microsoft/applications/events/maesdktest/MainActivity.java | Removed explicit maesdk library loading (handled by CMake now) |
| lib/android_build/app/src/androidTest/java/com/microsoft/applications/events/maesdktest/SDKUnitNativeTest.java | Removed explicit maesdk library loading |
| lib/android_build/app/src/androidTest/java/com/microsoft/applications/events/maesdktest/OfflineRoomUnitTest.java | Added test for lazy-loaded page size; updated deprecated assertion syntax |
| lib/android_build/app/build.gradle | Updated test dependencies to match maesdk module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/OfflineRoom.java
Outdated
Show resolved
Hide resolved
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/OfflineRoom.java
Outdated
Show resolved
Hide resolved
lib/android_build/maesdk/src/main/java/com/microsoft/applications/events/OfflineRoom.java
Show resolved
Hide resolved
...p/src/androidTest/java/com/microsoft/applications/events/maesdktest/OfflineRoomUnitTest.java
Outdated
Show resolved
Hide resolved
Contributor
…ons/events/OfflineRoom.java Co-authored-by: Copilot <[email protected]>
* Initial plan * Enhance loadPageSize test to verify valid page size Co-authored-by: anod <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: anod <[email protected]>
Contributor
… static lock (#1396) * Initial plan * Add thread-safety to initPageSize() using double-checked locking Co-authored-by: anod <[email protected]> * Use static lock object for thread-safety in initPageSize() Co-authored-by: anod <[email protected]> * Add concurrent test for thread-safe page size initialization Co-authored-by: anod <[email protected]> * Use ExecutorService instead of raw threads in concurrent test Co-authored-by: anod <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: anod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1372 Not Compatible with latest android room 2.7.2
Unblock android apps for upgrading Room library