Fix a bunch of additional warnings that only show up one at a time. Probably not all fo them

Author: dmachaj

cppwinrt/component_writers.h

@@ -754,7 +754,7 @@ catch (...) { return winrt::to_hresult(); }
         using implements_type = typename %_base::implements_type;
         using implements_type::implements_type;
         %%
-        hstring GetRuntimeClassName() const
+        hstring GetRuntimeClassName() const override
         {
             return L"%.%";
         }

strings/base_fast_forward.h

@@ -63,7 +63,7 @@ namespace winrt::impl
         std::atomic<uint32_t> m_references{ 1 };
 
         fast_abi_forwarder(void* owner, guid const& iid, std::size_t offset) noexcept :
-            m_vfptr(s_vtable), m_owner(static_cast<inspectable*>(owner)), m_iid(iid), m_offset(offset)
+            m_vfptr(s_vtable), m_owner(static_cast<inspectable*>(owner)), m_offset(offset), m_iid(iid)
         {
             m_owner->AddRef();
         }
@@ -116,6 +116,11 @@ namespace winrt::impl
             return self->m_owner->GetTrustLevel(level);
         }
 
+
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wmicrosoft-cast"
+#endif
         static inline void* const s_vtable[] =
         {
             QueryInterface,
@@ -125,6 +130,9 @@ namespace winrt::impl
             GetRuntimeClassName,
             GetTrustLevel,
 %        };
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
     };
 
     // Enforce assumptions made by thunk asm code

strings/base_string.h

@@ -574,8 +574,8 @@ namespace winrt::impl
         // when non-const (e.g. ranges::filter_view) so taking a const reference
         // as parameter wouldn't work for all scenarios.
         auto const size = std::formatted_size(args...);
-        WINRT_ASSERT(size < UINT_MAX);
-        auto const size32 = static_cast<uint32_t>(size);
+        WINRT_ASSERT(size < INT_MAX);
+        auto const size32 = static_cast<int32_t>(size);
 
         hstring_builder builder(size32);
         WINRT_VERIFY_(size32, std::format_to_n(builder.data(), size32, args...).size);

test/old_tests/Composable/Base.cpp

@@ -43,7 +43,7 @@ namespace winrt::Composable::implementation
 
     int32_t Base::ProtectedMethod()
     {
-        return 0xDEADBEEF;
+        return static_cast<int32_t>(0xDEADBEEF);
     }
 
     hstring Base::Name() const

test/old_tests/UnitTests/Boxing2.cpp

@@ -41,19 +41,19 @@ namespace
             REQUIRE(unbox_value_or<T>(wrong_type, v2) == v2);
         }
 
-        REQUIRE(object.as<T>() == v1);
-        REQUIRE(object.try_as<T>() == v1);
-        REQUIRE(nothing.try_as<T>() == std::nullopt);
+        REQUIRE(object.template as<T>() == v1);
+        REQUIRE(object.template try_as<T>() == v1);
+        REQUIRE(nothing.template try_as<T>() == std::nullopt);
         REQUIRE(wrong_type.try_as<T>() == std::nullopt);
 
         T result{ v2 };
-        object.as<T>(result);
+        object.template as<T>(result);
         REQUIRE(result == v1);
 
         result = v1;
         REQUIRE(v1 != empty<T>()); // Test must pass a v1 that is not equal to the empty value.
 
-        REQUIRE(!nothing.try_as<T>(result));
+        REQUIRE(!nothing.template try_as<T>(result));
         REQUIRE(result == empty<T>()); // try_as explicitly empties the result on failure
 
         result = v1;

test/old_tests/UnitTests/Composable.cpp

@@ -14,7 +14,7 @@ namespace
     constexpr auto Base_OverridableMethod{ L"Base::OverridableMethod"sv };
     constexpr auto Base_OverridableVirtualMethod{ L"Base::OverridableVirtualMethod"sv };
     constexpr auto Base_OverridableNoexceptMethod{ 42 };
-    constexpr auto Base_ProtectedMethod{ 0xDEADBEEF };
+    constexpr auto Base_ProtectedMethod{ static_cast<int32_t>(0xDEADBEEF) };
 
     constexpr auto Derived_VirtualMethod{ L"Derived::VirtualMethod"sv };
     constexpr auto Derived_OverridableVirtualMethod{ L"Derived::OverridableVirtualMethod"sv };

test/old_tests/UnitTests/IInspectable_GetRuntimeClassName.cpp

@@ -18,10 +18,17 @@ struct Test_GetRuntimeClassName_NoOverride : implements<Test_GetRuntimeClassName
 
 struct Test_GetRuntimeClassName_Override : implements<Test_GetRuntimeClassName_Override, Windows::Foundation::IInspectable>
 {
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
     hstring GetRuntimeClassName()
     {
         return L"GetRuntimeClassName";
     }
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
 };
 
 TEST_CASE("Test_GetRuntimeClassName_NoOverride")

test/old_tests/UnitTests/array.cpp

@@ -17,7 +17,7 @@ using namespace Windows::Security::Cryptography::Certificates;
 //
 // This is a helper to create a data reader for use in testing arrays.
 //
-static IAsyncOperation<IDataReader> CreateDataReader(std::initializer_list<byte> values)
+static IAsyncOperation<IDataReader> CreateDataReader(std::initializer_list<byte> /*values*/)
 {
     InMemoryRandomAccessStream stream;
     DataWriter writer(stream);

test/old_tests/UnitTests/produce.cpp

@@ -124,10 +124,17 @@ struct produce_IInspectable_No_RuntimeClassName : implements<produce_IInspectabl
 
 struct produce_IInspectable_RuntimeClassName : implements<produce_IInspectable_RuntimeClassName, Windows::Foundation::IInspectable>
 {
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
     hstring GetRuntimeClassName()
     {
         return L"produce_IInspectable_RuntimeClassName";
     }
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
 };
 
 TEST_CASE("produce_IInspectable_RuntimeClassName")

test/old_tests/UnitTests/smart_pointers.cpp

@@ -7,6 +7,12 @@ using namespace Windows::Foundation;
 using namespace Windows::Foundation::Collections;
 using namespace Component;
 
+
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Wself-assign-overloaded"
+#pragma clang diagnostic ignored "-Wself-move"
+#endif
+
 namespace
 {
     struct Type : implements<Type, IStringable>