-
Notifications
You must be signed in to change notification settings - Fork 1k
Docker Support for Issue Docker Support #85 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
Thanks for the PR, but we already have an existing PR for this: #90 . Would you mind looking at that one and let us know how this differs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR introduces Docker support for Data Formulator to simplify both development and production deployments. Key changes include:
- A multi-stage Dockerfile and docker-compose.yml for streamlined container management.
- New documentation in DOCKER.md and updates to README.md and DEVELOPMENT.md describing Docker deployment and development workflows.
Reviewed Changes
File | Description |
---|---|
DOCKER.md | Adds a complete Docker deployment guide outlining build, run, and configuration steps. |
README.md | Updates deployment instructions with code examples for Docker. |
docker-compose.yml | Introduces a Docker Compose configuration to simplify container orchestration. |
DEVELOPMENT.md | Updates local development instructions to include Docker-based workflows. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
|
||
1. **Build the Docker image:** | ||
|
||
```bash:README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code snippet marker incorrectly includes ':README.md'; this could affect markdown rendering. Please change it to '```bash' for proper syntax highlighting.
```bash:README.md | |
```bash |
Copilot uses AI. Check for mistakes.
I've implemented the streamlined Docker approach in this PR #85 based on several technical advantages that will improve performance, resource utilization, and deployment efficiency: Optimized Multi-stage Build Pipeline:
Reduced Container Size and Resource Footprint:
Enhanced CI/CD Integration:
Runtime Performance Improvements:
Centralized Environment Configuration:
|
I have briefly compared both PRs, mostly differs from how files are organized and options to deal with API keys etc. Though I currently have trouble work out either... so I'll try to look into what's the issues now. |
Sure .. If you need any help or clarification , reach out to me in this discussion |
Docker Support for Data Formulator
Overview
This PR adds comprehensive Docker support to Data Formulator, enabling easier deployment and development. The implementation includes multi-stage builds, environment variable management, and production-ready configurations.
Key Changes
Features
Documentation Updates
Related Files
Dependencies
Security Considerations
Breaking Changes
None. This is an additive change that maintains backward compatibility with existing deployment methods.
Future Work
@Chenglong-MS @danmarshall