Skip to content

Bug fix: Ensure we install visual C++ when dependency is missing #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonellaavogadro merged 2 commits into from
Apr 28, 2025
Merged

Bug fix: Ensure we install visual C++ when dependency is missing #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2b578a
install visual C++ appx
antonellaavogadro Apr 28, 2025
93bd80f
factorized architecture variable
antonellaavogadro Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions Tasks/git-clone/main.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,34 @@ function InstallWinGet {
if ($PsInstallScope -eq "CurrentUser") {
# Under a user account, the way to materialize winget.exe and make it work is by installing DesktopAppInstaller appx,
# which in turn may have Xaml and VC++ redistributable requirements.

$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}

$msVCLibsPackage = Get-AppxPackage -Name "Microsoft.VCLibs.140.00.UWPDesktop" | Where-Object { $_.Version -ge "14.0.30035.0" }
if (!($msVCLibsPackage)) {
# Install Microsoft.VCLibs.140.00.UWPDesktop
try {
Write-Host "Installing Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibs = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibsAppx = "$($MsVCLibs).appx"

Invoke-WebRequest -Uri "https://aka.ms/Microsoft.VCLibs.$($architecture).14.00.Desktop.appx" -OutFile $MsVCLibsAppx
Add-AppxPackage -Path $MsVCLibsAppx -ForceApplicationShutdown
Write-Host "Done Installing Microsoft.VCLibs.140.00.UWPDesktop"
} catch {
Write-Host "Failed to install Microsoft.VCLibs.140.00.UWPDesktop"
Write-Error $_
}
}

$msUiXamlPackage = Get-AppxPackage -Name "Microsoft.UI.Xaml.2.8" | Where-Object { $_.Version -ge "8.2310.30001.0" }
if (!($msUiXamlPackage)) {
# install Microsoft.UI.Xaml
try {
Write-Host "Installing Microsoft.UI.Xaml"
$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}
$MsUiXaml = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.UI.Xaml.2.8.6"
$MsUiXamlZip = "$($MsUiXaml).zip"
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.8.6" -OutFile $MsUiXamlZip
Expand Down
26 changes: 22 additions & 4 deletions Tasks/git-clone/runAsUser.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,33 @@ else {
Write-Host "Microsoft.WinGet.Configuration is already installed"
}

$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}

$msVCLibsPackage = Get-AppxPackage -Name "Microsoft.VCLibs.140.00.UWPDesktop" | Where-Object { $_.Version -ge "14.0.33728.0" }
if (!($msVCLibsPackage)) {
# Install Microsoft.VCLibs.140.00.UWPDesktop
try {
Write-Host "Installing Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibs = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibsAppx = "$($MsVCLibs).appx"

Invoke-WebRequest -Uri "https://aka.ms/Microsoft.VCLibs.$($architecture).14.00.Desktop.appx" -OutFile $MsVCLibsAppx
Add-AppxPackage -Path $MsVCLibsAppx -ForceApplicationShutdown
Write-Host "Done Installing Microsoft.VCLibs.140.00.UWPDesktop"
} catch {
Write-Host "Failed to install Microsoft.VCLibs.140.00.UWPDesktop"
Write-Error $_
}
}

$msUiXamlPackage = Get-AppxPackage -Name "Microsoft.UI.Xaml.2.8" | Where-Object { $_.Version -ge "8.2310.30001.0" }
if (!($msUiXamlPackage)) {
# install Microsoft.UI.Xaml
try{
Write-Host "Installing Microsoft.UI.Xaml"
$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}
$MsUiXaml = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.UI.Xaml.2.8.6"
$MsUiXamlZip = "$($MsUiXaml).zip"
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.8.6" -OutFile $MsUiXamlZip
Expand Down
27 changes: 23 additions & 4 deletions Tasks/winget/main.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,34 @@ function InstallWinGet {
}

if ($PsInstallScope -eq "CurrentUser") {

$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}

$msVCLibsPackage = Get-AppxPackage -Name "Microsoft.VCLibs.140.00.UWPDesktop" | Where-Object { $_.Version -ge "14.0.30035.0" }
if (!($msVCLibsPackage)) {
# Install Microsoft.VCLibs.140.00.UWPDesktop
try {
Write-Host "Installing Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibs = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibsAppx = "$($MsVCLibs).appx"

Invoke-WebRequest -Uri "https://aka.ms/Microsoft.VCLibs.$($architecture).14.00.Desktop.appx" -OutFile $MsVCLibsAppx
Add-AppxPackage -Path $MsVCLibsAppx -ForceApplicationShutdown
Write-Host "Done Installing Microsoft.VCLibs.140.00.UWPDesktop"
} catch {
Write-Host "Failed to install Microsoft.VCLibs.140.00.UWPDesktop"
Write-Error $_
}
}

$msUiXamlPackage = Get-AppxPackage -Name "Microsoft.UI.Xaml.2.8" | Where-Object { $_.Version -ge "8.2310.30001.0" }
if (!($msUiXamlPackage)) {
# instal Microsoft.UI.Xaml
try {
Write-Host "Installing Microsoft.UI.Xaml"
$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}
$MsUiXaml = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.UI.Xaml.2.8.6"
$MsUiXamlZip = "$($MsUiXaml).zip"
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.8.6" -OutFile $MsUiXamlZip
Expand Down
26 changes: 22 additions & 4 deletions Tasks/winget/runAsUser.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,33 @@ else {
Write-Host "Microsoft.WinGet.Configuration is already installed"
}

$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}

$msVCLibsPackage = Get-AppxPackage -Name "Microsoft.VCLibs.140.00.UWPDesktop" | Where-Object { $_.Version -ge "14.0.30035.0" }
if (!($msVCLibsPackage)) {
# Install Microsoft.VCLibs.140.00.UWPDesktop
try {
Write-Host "Installing Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibs = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.VCLibs.140.00.UWPDesktop"
$MsVCLibsAppx = "$($MsVCLibs).appx"

Invoke-WebRequest -Uri "https://aka.ms/Microsoft.VCLibs.$($architecture).14.00.Desktop.appx" -OutFile $MsVCLibsAppx
Add-AppxPackage -Path $MsVCLibsAppx -ForceApplicationShutdown
Write-Host "Done Installing Microsoft.VCLibs.140.00.UWPDesktop"
} catch {
Write-Host "Failed to install Microsoft.VCLibs.140.00.UWPDesktop"
Write-Error $_
}
}

$msUiXamlPackage = Get-AppxPackage -Name "Microsoft.UI.Xaml.2.8" | Where-Object { $_.Version -ge "8.2310.30001.0" }
if (!($msUiXamlPackage)) {
# instal Microsoft.UI.Xaml
try{
Write-Host "Installing Microsoft.UI.Xaml"
$architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
$architecture = "arm64"
}
$MsUiXaml = "$env:TEMP\$([System.IO.Path]::GetRandomFileName())-Microsoft.UI.Xaml.2.8.6"
$MsUiXamlZip = "$($MsUiXaml).zip"
Invoke-WebRequest -Uri "https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.8.6" -OutFile $MsUiXamlZip
Expand Down
Loading