chore: main branch image migration #269
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes updates to the Docker build and push workflow, and modifications to the infrastructure configuration files to support a new container registry and additional parameters.
GitHub Actions Workflow Updates:
.github/workflows/docker-build-and-push.yml: Updated the Docker login steps to distinguish between external and internal registries and modified the logic to set registry variables based on the branch name. Additionally, separate steps were added to build and push Docker images to internal and external registries. [1] [2] [3]Infrastructure Configuration Updates:
infra/main.bicep: Changed theWebAppImageNamevariable to use a new container registry URL.infra/main.json: Added a newenvironmentNameparameter with validation constraints and updated theWebAppImageNamevariable to use the new container registry URL. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information