Skip to content

Conversation

@Harsh-Microsoft
Copy link
Contributor

@Harsh-Microsoft Harsh-Microsoft commented Mar 7, 2025

Purpose

This pull request includes updates to the Docker build and push workflow as well as changes to the infrastructure configuration files. The most important changes focus on improving the handling of different registries.

Changes to Docker build and push workflow:

Changes to infrastructure configuration:

  • infra/main.bicep: Updated the WebAppImageName variable to use a new container registry URL.
  • infra/main.json: Added a new parameter environmentName for resource prefix and updated the WebAppImageName variable. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

Roopan-Microsoft and others added 2 commits March 7, 2025 20:05
@Prajwal-Microsoft Prajwal-Microsoft merged commit 6997017 into dev Mar 7, 2025
5 checks passed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Harsh-Microsoft Harsh-Microsoft deleted the image-migration branch April 3, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants