chore: main branch image migration to internal registry #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes updates to the Docker build and push workflow as well as changes to the infrastructure configuration files. The most important changes focus on improving the handling of different registries.
Changes to Docker build and push workflow:
.github/workflows/docker-build-and-push.yml: Modified the registry retrieval logic to handle both external and internal registries..github/workflows/docker-build-and-push.yml: Added separate steps for building and pushing Docker images to internal and external registries.Changes to infrastructure configuration:
infra/main.bicep: Updated theWebAppImageNamevariable to use a new container registry URL.infra/main.json: Added a new parameterenvironmentNamefor resource prefix and updated theWebAppImageNamevariable. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information