Skip to content

Conversation

@AjitPadhi-Microsoft
Copy link
Contributor

@AjitPadhi-Microsoft AjitPadhi-Microsoft commented Sep 4, 2025

Purpose

  • This pull request introduces significant enhancements to the Azure infrastructure deployment for the Multi Agent Solution Accelerator. The main improvements include the addition of production-ready (WAF-aligned) deployment configuration, new modular Bicep files for AI project and Cognitive Services deployments, expanded and more secure network configuration, and parameter naming clarifications. These changes make the solution more robust, secure, and easier to adapt for both sandbox and production environments.

Deployment Documentation and Configuration:

  • Expanded the deployment guide (docs/DeploymentGuide.md) to clarify the difference between sandbox and Well-Architected Framework (WAF)-aligned production deployments, including instructions for choosing and customizing deployment parameters and VM credentials.

Infrastructure as Code Improvements:

  • Added a new production-ready parameter file infra/main.waf.parameters.json with enhanced security, monitoring, scalability, and private networking enabled by default for WAF-aligned deployments.

Network and Security Improvements:

  • Introduced a new infra/modules/network.bicep module with detailed parameterization, best practices for subnetting, secure NSG rules, Bastion and Jumpbox configuration, and outputting key resource IDs for downstream use.

These updates collectively make the infrastructure more modular, secure, and easier to deploy in both development and production contexts.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@AjitPadhi-Microsoft AjitPadhi-Microsoft changed the title Psl wafstandard feat: avm waf standardization Sep 12, 2025
@AjitPadhi-Microsoft AjitPadhi-Microsoft marked this pull request as ready for review September 12, 2025 07:55
@Prajwal-Microsoft Prajwal-Microsoft merged commit c696de4 into dev Sep 12, 2025
5 checks passed
@AjitPadhi-Microsoft AjitPadhi-Microsoft deleted the psl-wafstandard branch September 12, 2025 10:49
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants