Skip to content

Conversation

lbussell
Copy link
Collaborator

When running the current scripts on Windows, the script tries to copy files from a container that doesn't exist because Invoke-ImageBuilder.ps1 does not create a container on Windows. As a result it throws some warnings/errors and the command "fails" even though it does what you want:

PS> pwsh .\eng\readme-templates\Get-GeneratedReadmes.ps1
...
Executing: 'docker cp ImageBuilder-20250228105133:/repo/README.aspnet.md C:\...\dotnet-framework-docker/'
Error response from daemon: No such container: ImageBuilder-20250228105133
PS> $?
False

This PR skips the copy on Windows. I made sure it works on all three of Windows PowerShell, PowerShell Core on Windows, and PowerShell Core on Linux.

@lbussell lbussell requested a review from a team as a code owner February 28, 2025 18:55
@lbussell lbussell requested a review from mthalman February 28, 2025 19:31
@lbussell lbussell merged commit dddd046 into microsoft:main Feb 28, 2025
24 checks passed
lbussell added a commit to dotnet/docker-tools that referenced this pull request Mar 5, 2025
lbussell added a commit to dotnet/docker-tools that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants