Use NuGet packages to install reference assemblies / targeting packs #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2025
|
@lbussell, Can you call out the impact of the xml files being removed in the description? This should be flagged as needing an announcement. |
lbussell
added
the
needs-announcement
mthalman
reviewed
Mar 5, 2025
eng/dockerfile-templates/sdk/Dockerfile.install-reference-assemblies
Outdated
Show resolved
Hide resolved
eng/dockerfile-templates/sdk/Dockerfile.install-reference-assemblies
Outdated
Show resolved
Hide resolved
eng/dockerfile-templates/sdk/Dockerfile.install-reference-assemblies
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Thalman <[email protected]>
mthalman
previously approved these changes
Mar 5, 2025
|
Taking a deeper look at the IntelliSense files:
Using Old imageNew imageSo, it seems the current code for stripping the files doesn't work. I'll take another look at it. |
NikolaMilosavljevic
approved these changes
Mar 7, 2025
|
The issue was the regex escaping, I fixed it (and simplified it a little). New list of XML files: It is 458 KB of files instead of 800+ MB like before. XML Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of [Minimize usage of
dotnetbinariesstorage account (#1221)](#1221). Supersedes [Use combined reference assembly/targeting pack zip file (#1217)](#1217).This improves targeting pack acquisition by downloading them from NuGet packages instead of using files that we host ourselves.
This also fixes #1135. Or rather, makes it irrelevant, since we should prefer to host no files at all, even if we still need to use a for loop.