Fix method ordering, xmldoc, and remove obsolete XUnit verifiers#367
Merged
jviau merged 4 commits intomicrosoft:mainfrom Jan 27, 2025
Merged
Fix method ordering, xmldoc, and remove obsolete XUnit verifiers#367jviau merged 4 commits intomicrosoft:mainfrom
jviau merged 4 commits intomicrosoft:mainfrom
Conversation
cgillum
reviewed
Jan 25, 2025
test/Analyzers.Tests/Orchestration/DateTimeOrchestrationAnalyzerTests.cs
Show resolved
Hide resolved
cgillum
approved these changes
Jan 27, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
PR looks good. A couple questions and one minor suggestion on the package description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some warnings to get back to 0 warnings