Include Exception Properties at FailureDetails

src/Abstractions/DurableTaskCoreExceptionsExtensions.cs

@@ -49,6 +49,7 @@
             failureDetails.ErrorType,
             failureDetails.ErrorMessage,
             failureDetails.StackTrace,
-            failureDetails.InnerFailure?.ToTaskFailureDetails());
+            failureDetails.InnerFailure?.ToTaskFailureDetails(),
+            failureDetails.Properties);
     }
 }

src/Abstractions/TaskFailureDetails.cs

@@ -15,7 +15,8 @@
 /// <param name="ErrorMessage">A summary description of the failure.</param>
 /// <param name="StackTrace">The stack trace of the failure.</param>
 /// <param name="InnerFailure">The inner cause of the task failure.</param>
-public record TaskFailureDetails(string ErrorType, string ErrorMessage, string? StackTrace, TaskFailureDetails? InnerFailure)
+/// <param name="Properties">Additional properties associated with the exception.</param>
+public record TaskFailureDetails(string ErrorType, string ErrorMessage, string? StackTrace, TaskFailureDetails? InnerFailure, IDictionary<string, object?>? Properties)
 {
     Type? loadedExceptionType;
 
@@ -118,12 +119,13 @@
     /// <returns>A new <see cref="CoreFailureDetails"/> instance.</returns>
     internal CoreFailureDetails ToCoreFailureDetails()
     {
         return new CoreFailureDetails(
             this.ErrorType,
             this.ErrorMessage,
             this.StackTrace,
             this.InnerFailure?.ToCoreFailureDetails(),
-            isNonRetriable: false);
+            isNonRetriable: false,
+            this.Properties);
     }
 
     /// <summary>
@@ -143,7 +145,8 @@
             coreFailureDetails.ErrorType,
             coreFailureDetails.ErrorMessage,
             coreFailureDetails.StackTrace,
-            FromCoreFailureDetails(coreFailureDetails.InnerFailure));
+            FromCoreFailureDetails(coreFailureDetails.InnerFailure),
+            coreFailureDetails.Properties);
     }
 
     [return: NotNullIfNotNull(nameof(exception))]
@@ -160,14 +163,16 @@
                 coreEx.FailureDetails?.ErrorType ?? "(unknown)",
                 coreEx.FailureDetails?.ErrorMessage ?? "(unknown)",
                 coreEx.FailureDetails?.StackTrace,
-                FromCoreFailureDetailsRecursive(coreEx.FailureDetails?.InnerFailure) ?? FromExceptionRecursive(coreEx.InnerException));
+                FromCoreFailureDetailsRecursive(coreEx.FailureDetails?.InnerFailure) ?? FromExceptionRecursive(coreEx.InnerException),
+                coreEx.FailureDetails?.Properties ?? null);
         }
 
         return new TaskFailureDetails(
             exception.GetType().ToString(),
             exception.Message,
             exception.StackTrace,
-            FromExceptionRecursive(exception.InnerException));
+            FromExceptionRecursive(exception.InnerException),
+            null);// might need to udpate this later 
     }
 
     static TaskFailureDetails? FromCoreFailureDetailsRecursive(CoreFailureDetails? coreFailureDetails)
@@ -181,6 +186,7 @@
             coreFailureDetails.ErrorType,
             coreFailureDetails.ErrorMessage,
             coreFailureDetails.StackTrace,
-            FromCoreFailureDetailsRecursive(coreFailureDetails.InnerFailure));
+            FromCoreFailureDetailsRecursive(coreFailureDetails.InnerFailure),
+            coreFailureDetails.Properties);
     }
 }

src/Client/OrchestrationServiceClientShim/ShimExtensions.cs

@@ -75,7 +75,7 @@ public static Core.OrchestrationStatus ConvertToCore(this OrchestrationRuntimeSt
         }
 
         TaskFailureDetails? inner = details.InnerFailure?.ConvertFromCore();
-        return new TaskFailureDetails(details.ErrorType, details.ErrorMessage, details.StackTrace, inner);
+        return new TaskFailureDetails(details.ErrorType, details.ErrorMessage, details.StackTrace, inner, details.Properties);
     }
 
     /// <summary>