Extended sessions for entities in .NET isolated #507

sophiatev · 2025-11-20T00:28:50Z

This PR introduces the extended sessions feature for entities in .NET isolated. It essentially copies what was done to enable extended sessions for orchestrations in the GrpcOrchestrationRunner into the GrpcEntityRunner, and introduces a new class for shared logic between the two.

…lated

…added tests

Copilot

Pull Request Overview

This PR extends the extended sessions feature to entities in .NET isolated, bringing entities to feature parity with orchestrations. The implementation refactors shared logic between GrpcOrchestrationRunner and GrpcEntityRunner into a new utility class and applies the same extended session caching pattern to entities.

Key Changes:

Introduced GrpcInstanceRunnerUtils to share request property parsing and cache initialization logic
Added extended sessions support to GrpcEntityRunner with state caching capabilities
Updated parameter naming from IncludePastEvents to IncludeState throughout tests for consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/Worker/Grpc/GrpcInstanceRunnerUtils.cs	New utility class containing shared logic for parsing request properties and initializing extended sessions cache
src/Worker/Grpc/GrpcEntityRunner.cs	Added new overload with extended sessions support and implemented entity state caching logic
src/Worker/Grpc/GrpcOrchestrationRunner.cs	Refactored to use shared utility for request property parsing and cache initialization
test/Worker/Grpc.Tests/GrpcEntityRunnerTests.cs	New comprehensive test suite covering extended sessions scenarios for entities
test/Worker/Grpc.Tests/GrpcOrchestrationRunnerTests.cs	Updated tests to use `IncludeState` parameter naming and improved variable naming consistency

Comments suppressed due to low confidence (1)

src/Worker/Grpc/GrpcOrchestrationRunner.cs:210

Variable extendedSessions may be null at this access as suggested by this null check.
Variable extendedSessions may be null at this access as suggested by this null check.

                    extendedSessions.Set<ExtendedSessionState>(

Copilot · 2025-11-20T00:33:35Z

src/Worker/Grpc/GrpcInstanceRunnerUtils.cs

+    /// </summary>
+    /// <remarks>
+    /// If any request property is missing or invalid (i.e. the key is misspelled or the value is of the wrong type),
+    /// extended sessions are not enabled and default values are assigned are assigned to the returns.


Duplicate word "are assigned" in the documentation. Should be "extended sessions are not enabled and default values are assigned to the returns."

Suggested change

/// extended sessions are not enabled and default values are assigned are assigned to the returns.

/// extended sessions are not enabled and default values are assigned to the returns.

Copilot · 2025-11-20T00:33:35Z

src/Worker/Grpc/GrpcInstanceRunnerUtils.cs

+
+using System;
+using System.Collections.Generic;
+using System.Text;


Unused using statement for System.Text. This namespace appears to be included but not used anywhere in the file.

Suggested change

using System.Text;

Copilot · 2025-11-20T00:33:36Z

test/Worker/Grpc.Tests/GrpcEntityRunnerTests.cs

+        byte[] requestBytes = entityRequest.ToByteArray();
+        string requestString = Convert.ToBase64String(requestBytes);
+        string responseString = await GrpcEntityRunner.LoadAndRunAsync(requestString, new SimpleEntity(), extendedSessions);
+        Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));


Incorrect response type used. The test parses the response as Protobuf.OrchestratorResponse when it should be Protobuf.EntityBatchResult (as used in the other tests).

Suggested change

Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));

Protobuf.EntityBatchResult response = Protobuf.EntityBatchResult.Parser.ParseFrom(Convert.FromBase64String(responseString));

Copilot · 2025-11-20T00:33:36Z

src/Worker/Grpc/GrpcEntityRunner.cs

+            addToExtendedSessions = true;
+
+            // If an entity state was provided, even if we already have one stored, we always want to use the provided state.
+            if (!entityStateIncluded && extendedSessions.TryGetValue(request.InstanceId, out string? entityState))


Missing null check for cached entity state. If a null value is stored in the cache (similar to the scenario tested in GrpcOrchestrationRunnerTests.NullExtendedSessionStored_Means_NeedsExtendedSessionNotUsed), this code will incorrectly set stateCached = true and use the null state. The orchestration runner has an explicit && extendedSessionState is not null check on line 149 of GrpcOrchestrationRunner.cs that should be mirrored here. The condition should be:

if (!entityStateIncluded && extendedSessions.TryGetValue(request.InstanceId, out string? entityState) && entityState is not null)

Suggested change

if (!entityStateIncluded && extendedSessions.TryGetValue(request.InstanceId, out string? entityState))

if (!entityStateIncluded && extendedSessions.TryGetValue(request.InstanceId, out string? entityState) && entityState is not null)

Copilot · 2025-11-20T00:33:36Z

test/Worker/Grpc.Tests/GrpcEntityRunnerTests.cs

+        return entityBatchRequest;
+    }
+
+    class SimpleEntity : TaskEntity<int?>


Private test class should be sealed. According to the coding guidelines, "Ensure that all private classes, that do not serve as base classes, are sealed." This class should be declared as sealed class SimpleEntity : TaskEntity<int?>.

Copilot · 2025-11-20T00:33:36Z

src/Worker/Grpc/GrpcEntityRunner.cs

+
+        if (addToExtendedSessions)
+        {
+            extendedSessions.Set(


Variable extendedSessions may be null at this access as suggested by this null check.
Variable extendedSessions may be null at this access as suggested by this null check.

Suggested change

extendedSessions.Set(

extendedSessions?.Set(

Copilot · 2025-11-20T00:33:37Z

test/Worker/Grpc.Tests/GrpcEntityRunnerTests.cs

+        byte[] requestBytes = entityRequest.ToByteArray();
+        string requestString = Convert.ToBase64String(requestBytes);
+        string responseString = await GrpcEntityRunner.LoadAndRunAsync(requestString, new SimpleEntity(), extendedSessions);
+        Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));


This assignment to response is useless, since its value is never read.

Suggested change

Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));

Copilot · 2025-11-20T00:33:37Z

test/Worker/Grpc.Tests/GrpcOrchestrationRunnerTests.cs

-        string stringResponse = GrpcOrchestrationRunner.LoadAndRun(requestString, new SimpleOrchestrator(), extendedSessions);
-        Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(stringResponse));
+        string responseString = GrpcOrchestrationRunner.LoadAndRun(requestString, new SimpleOrchestrator(), extendedSessions);
+        Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));


This assignment to response is useless, since its value is never read.

Suggested change

Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));

Sophia Tevosyan added 6 commits July 11, 2025 12:50

first commit

8ec7ed1

Merge branch 'main' into stevosyan/extended-sessions-for-entities-iso…

ef046b5

…lated

updated implementation to match the orchestration implementation and …

7b84f2e

…added tests

updated tests

464ad23

refactoring

21512fd

removed assumption that null entity state is invalid

e036914

Copilot AI review requested due to automatic review settings November 20, 2025 00:28

Copilot started reviewing on behalf of sophiatev November 20, 2025 00:29 View session

Copilot finished reviewing on behalf of sophiatev November 20, 2025 00:32

Copilot AI reviewed Nov 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extended sessions for entities in .NET isolated #507

Extended sessions for entities in .NET isolated #507

Uh oh!

sophiatev commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Copilot AI Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// extended sessions are not enabled and default values are assigned are assigned to the returns.
	/// extended sessions are not enabled and default values are assigned to the returns.

	Protobuf.OrchestratorResponse response = Protobuf.OrchestratorResponse.Parser.ParseFrom(Convert.FromBase64String(responseString));
	Protobuf.EntityBatchResult response = Protobuf.EntityBatchResult.Parser.ParseFrom(Convert.FromBase64String(responseString));

	if (!entityStateIncluded && extendedSessions.TryGetValue(request.InstanceId, out string? entityState))
	if (!entityStateIncluded && extendedSessions.TryGetValue(request.InstanceId, out string? entityState) && entityState is not null)

Extended sessions for entities in .NET isolated #507

Are you sure you want to change the base?

Extended sessions for entities in .NET isolated #507

Uh oh!

Conversation

sophiatev commented Nov 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants