Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the v1.17.2 release by bumping the version number from 1.17.1 to 1.17.2 and adding changelog entries documenting the changes included in this release. The release includes 11 PRs covering features like TaskEntity support in source generators, dependency updates, bug fixes, and project configuration improvements.
Key Changes:
- Version number incremented to 1.17.2 in Release.props
- Changelog updated with 11 entries detailing merged PRs for this release
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| eng/targets/Release.props | Increments VersionPrefix from 1.17.1 to 1.17.2 |
| CHANGELOG.md | Adds v1.17.2 section with changelog entries for 11 merged PRs |
| - Bump google.protobuf by dependabot[bot] ([#529](https://github.com/microsoft/durabletask-dotnet/pull/529)) | ||
| - Configure dependabot for dotnet-sdk updates by Tomer Rosenthal ([#524](https://github.com/microsoft/durabletask-dotnet/pull/524)) | ||
| - Add code review guidelines to copilot-instructions.md by Copilot ([#522](https://github.com/microsoft/durabletask-dotnet/pull/522)) | ||
| - Remove webapi sample by sophiatev ([#520](https://github.com/microsoft/durabletask-dotnet/pull/520)) |
There was a problem hiding this comment.
The changelog entry text should use proper capitalization. "webapi" should be "WebAPI" to match standard naming conventions for web API terminology.
Suggested change
| - Remove webapi sample by sophiatev ([#520](https://github.com/microsoft/durabletask-dotnet/pull/520)) | |
| - Remove WebAPI sample by sophiatev ([#520](https://github.com/microsoft/durabletask-dotnet/pull/520)) |
| - Configure dependabot for dotnet-sdk updates by Tomer Rosenthal ([#524](https://github.com/microsoft/durabletask-dotnet/pull/524)) | ||
| - Add code review guidelines to copilot-instructions.md by Copilot ([#522](https://github.com/microsoft/durabletask-dotnet/pull/522)) | ||
| - Remove webapi sample by sophiatev ([#520](https://github.com/microsoft/durabletask-dotnet/pull/520)) | ||
| - Fix functioncontext check and polymorphic type conversions in activity analyzer by Naiyuan Tian ([#506](https://github.com/microsoft/durabletask-dotnet/pull/506)) |
There was a problem hiding this comment.
Technical terms should use proper casing for consistency.
Suggested corrections:
- "functioncontext" → "FunctionContext"
Suggested change
| - Fix functioncontext check and polymorphic type conversions in activity analyzer by Naiyuan Tian ([#506](https://github.com/microsoft/durabletask-dotnet/pull/506)) | |
| - Fix FunctionContext check and polymorphic type conversions in activity analyzer by Naiyuan Tian ([#506](https://github.com/microsoft/durabletask-dotnet/pull/506)) |
| - Add code review guidelines to copilot-instructions.md by Copilot ([#522](https://github.com/microsoft/durabletask-dotnet/pull/522)) | ||
| - Remove webapi sample by sophiatev ([#520](https://github.com/microsoft/durabletask-dotnet/pull/520)) | ||
| - Fix functioncontext check and polymorphic type conversions in activity analyzer by Naiyuan Tian ([#506](https://github.com/microsoft/durabletask-dotnet/pull/506)) | ||
| - Align waitforexternalevent waiter picking order to lifo by wangbill ([#509](https://github.com/microsoft/durabletask-dotnet/pull/509)) |
There was a problem hiding this comment.
Technical terms should use proper casing for consistency.
Suggested corrections:
- "waitforexternalevent" → "WaitForExternalEvent"
- "lifo" → "LIFO"
Suggested change
| - Align waitforexternalevent waiter picking order to lifo by wangbill ([#509](https://github.com/microsoft/durabletask-dotnet/pull/509)) | |
| - Align WaitForExternalEvent waiter picking order to LIFO by wangbill ([#509](https://github.com/microsoft/durabletask-dotnet/pull/509)) |
| - Remove webapi sample by sophiatev ([#520](https://github.com/microsoft/durabletask-dotnet/pull/520)) | ||
| - Fix functioncontext check and polymorphic type conversions in activity analyzer by Naiyuan Tian ([#506](https://github.com/microsoft/durabletask-dotnet/pull/506)) | ||
| - Align waitforexternalevent waiter picking order to lifo by wangbill ([#509](https://github.com/microsoft/durabletask-dotnet/pull/509)) | ||
| - Update project to support .net 6.0 alongside .net 8.0 and .net 10 by Tomer Rosenthal ([#512](https://github.com/microsoft/durabletask-dotnet/pull/512)) |
There was a problem hiding this comment.
.NET should be capitalized consistently as ".NET" rather than ".net" to follow Microsoft's official branding guidelines.
Suggested change
| - Update project to support .net 6.0 alongside .net 8.0 and .net 10 by Tomer Rosenthal ([#512](https://github.com/microsoft/durabletask-dotnet/pull/512)) | |
| - Update project to support .NET 6.0 alongside .NET 8.0 and .NET 10 by Tomer Rosenthal ([#512](https://github.com/microsoft/durabletask-dotnet/pull/512)) |
Comment on lines
+12
to
+13
| - Update project to support .net 6.0 alongside .net 8.0 and .net 10 by Tomer Rosenthal ([#512](https://github.com/microsoft/durabletask-dotnet/pull/512)) | ||
| - Update project to target .net 8.0 and .net 10 and upgrade dependencies by Tomer Rosenthal ([#510](https://github.com/microsoft/durabletask-dotnet/pull/510)) |
There was a problem hiding this comment.
.NET should be capitalized consistently as ".NET" rather than ".net" to follow Microsoft's official branding guidelines.
Suggested change
| - Update project to support .net 6.0 alongside .net 8.0 and .net 10 by Tomer Rosenthal ([#512](https://github.com/microsoft/durabletask-dotnet/pull/512)) | |
| - Update project to target .net 8.0 and .net 10 and upgrade dependencies by Tomer Rosenthal ([#510](https://github.com/microsoft/durabletask-dotnet/pull/510)) | |
| - Update project to support .NET 6.0 alongside .NET 8.0 and .NET 10 by Tomer Rosenthal ([#512](https://github.com/microsoft/durabletask-dotnet/pull/512)) | |
| - Update project to target .NET 8.0 and .NET 10 and upgrade dependencies by Tomer Rosenthal ([#510](https://github.com/microsoft/durabletask-dotnet/pull/510)) |
| # Changelog | ||
|
|
||
| ## v1.17.2 | ||
| - Add taskentity support to durabletasksourcegenerator by Copilot ([#517](https://github.com/microsoft/durabletask-dotnet/pull/517)) |
There was a problem hiding this comment.
The changelog entry text uses inconsistent capitalization compared to other releases. Product names, type names, and technical terms should use proper casing.
Suggested corrections:
- "taskentity" → "TaskEntity"
- "durabletasksourcegenerator" → "DurableTaskSourceGenerator"
Suggested change
| - Add taskentity support to durabletasksourcegenerator by Copilot ([#517](https://github.com/microsoft/durabletask-dotnet/pull/517)) | |
| - Add TaskEntity support to DurableTaskSourceGenerator by Copilot ([#517](https://github.com/microsoft/durabletask-dotnet/pull/517)) |
|
|
||
| ## v1.17.2 | ||
| - Add taskentity support to durabletasksourcegenerator by Copilot ([#517](https://github.com/microsoft/durabletask-dotnet/pull/517)) | ||
| - Bump azure.identity by dependabot[bot] ([#525](https://github.com/microsoft/durabletask-dotnet/pull/525)) |
There was a problem hiding this comment.
Package names should use proper casing for consistency with NuGet conventions. "azure.identity" should be "Azure.Identity".
Suggested change
| - Bump azure.identity by dependabot[bot] ([#525](https://github.com/microsoft/durabletask-dotnet/pull/525)) | |
| - Bump Azure.Identity by dependabot[bot] ([#525](https://github.com/microsoft/durabletask-dotnet/pull/525)) |
| ## v1.17.2 | ||
| - Add taskentity support to durabletasksourcegenerator by Copilot ([#517](https://github.com/microsoft/durabletask-dotnet/pull/517)) | ||
| - Bump azure.identity by dependabot[bot] ([#525](https://github.com/microsoft/durabletask-dotnet/pull/525)) | ||
| - Bump google.protobuf by dependabot[bot] ([#529](https://github.com/microsoft/durabletask-dotnet/pull/529)) |
There was a problem hiding this comment.
Package names should use proper casing for consistency with NuGet conventions. "google.protobuf" should be "Google.Protobuf".
Suggested change
| - Bump google.protobuf by dependabot[bot] ([#529](https://github.com/microsoft/durabletask-dotnet/pull/529)) | |
| - Bump Google.Protobuf by dependabot[bot] ([#529](https://github.com/microsoft/durabletask-dotnet/pull/529)) |
kaibocai
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project for the v1.17.2 release, including versioning changes and a changelog update to document new features, dependency updates, and improvements.
Release updates:
VersionPrefixineng/targets/Release.propsto1.17.2to reflect the new release version.CHANGELOG.mdwith entries for new features (e.g., taskentity support), dependency bumps, configuration changes, documentation improvements, sample removal, bug fixes, and framework support updates.