Skip to content

Comments

Add Tags to CreateSubOrchestrationAction#558

Merged
sophiatev merged 5 commits intomainfrom
stevosyan/add-tags-to-create-sub-proto
Dec 15, 2025
Merged

Add Tags to CreateSubOrchestrationAction#558
sophiatev merged 5 commits intomainfrom
stevosyan/add-tags-to-create-sub-proto

Conversation

@sophiatev
Copy link
Contributor

@sophiatev sophiatev commented Dec 11, 2025

This small PR serializes the tags field and adds it to the CreateSubOrchestrationAction proto to enable adding user tags to suborchestrations.

Resolves #399

Copilot AI review requested due to automatic review settings December 11, 2025 18:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for serializing tags on suborchestration actions by adding a tags field to the CreateSubOrchestrationAction protobuf message and implementing the serialization logic in ProtoUtils.cs. The implementation follows the same pattern used for ScheduleTaskAction tags serialization.

Key Changes:

  • Added map<string, string> tags field to CreateSubOrchestrationAction proto message
  • Implemented tags serialization in ProtoUtils.cs for CreateSubOrchestrationAction

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Grpc/orchestrator_service.proto Added tags field to CreateSubOrchestrationAction message; also contains unrelated changes to OrchestratorResponse (isPartial and chunkIndex fields)
src/Shared/Grpc/ProtoUtils.cs Added tags serialization logic for CreateSubOrchestrationAction, mirroring the existing pattern for ScheduleTaskAction

Copilot AI review requested due to automatic review settings December 12, 2025 01:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@YunchuWang YunchuWang self-requested a review December 12, 2025 16:15
@sophiatev sophiatev merged commit bb5e6a4 into main Dec 15, 2025
7 checks passed
@sophiatev sophiatev deleted the stevosyan/add-tags-to-create-sub-proto branch December 15, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for sub-orchestration tags

2 participants