Skip to content

Change FunctionNotFound analyzer severity to Info for cross-assembly scenarios #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YunchuWang merged 4 commits into from
Dec 20, 2025
Merged

Change FunctionNotFound analyzer severity to Info for cross-assembly scenarios #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25eaebc
Initial plan
Copilot Dec 19, 2025
e3324ef
Change DURABLE2003/2004 severity to Info and update messages per issu…
Copilot Dec 19, 2025
31dec89
Merge branch 'main' into copilot/update-functionnotfound-analyzer
YunchuWang Dec 20, 2025
3280d54
Merge branch 'main' into copilot/update-functionnotfound-analyzer
YunchuWang Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Analyzers/Activities/FunctionNotFoundAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/// <summary>
/// Analyzer that detects calls to non-existent activities and sub-orchestrations.
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp)]

Check warning on line 16 in src/Analyzers/Activities/FunctionNotFoundAnalyzer.cs

View workflow job for this annotation

GitHub Actions / Analyze (csharp) 

This compiler extension should not be implemented in an assembly containing a reference to Microsoft.CodeAnalysis.Workspaces. The Microsoft.CodeAnalysis.Workspaces assembly is not provided during command line compilation scenarios, so references to it could cause the compiler extension to behave unpredictably. (https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md)

Check warning on line 16 in src/Analyzers/Activities/FunctionNotFoundAnalyzer.cs

View workflow job for this annotation

GitHub Actions / build 

This compiler extension should not be implemented in an assembly containing a reference to Microsoft.CodeAnalysis.Workspaces. The Microsoft.CodeAnalysis.Workspaces assembly is not provided during command line compilation scenarios, so references to it could cause the compiler extension to behave unpredictably. (https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md)
public sealed class FunctionNotFoundAnalyzer : DiagnosticAnalyzer
{
/// <summary>
Expand All @@ -37,7 +37,7 @@
ActivityNotFoundTitle,
ActivityNotFoundMessageFormat,
AnalyzersCategories.Activity,
DiagnosticSeverity.Warning,
DiagnosticSeverity.Info,
customTags: [WellKnownDiagnosticTags.CompilationEnd],
isEnabledByDefault: true,
helpLinkUri: "https://go.microsoft.com/fwlink/?linkid=2346202");
Expand All @@ -47,7 +47,7 @@
SubOrchestrationNotFoundTitle,
SubOrchestrationNotFoundMessageFormat,
AnalyzersCategories.Orchestration,
DiagnosticSeverity.Warning,
DiagnosticSeverity.Info,
customTags: [WellKnownDiagnosticTags.CompilationEnd],
isEnabledByDefault: true,
helpLinkUri: "https://go.microsoft.com/fwlink/?linkid=2346202");
Expand Down
4 changes: 2 additions & 2 deletions src/Analyzers/AnalyzerReleases.Shipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

Rule ID | Category | Severity | Notes
--------|----------|----------|-------
DURABLE2003 | Activity | Warning | **FunctionNotFoundAnalyzer**: Warns when an activity function call references a name that does not match any defined activity in the compilation.
DURABLE2004 | Orchestration | Warning | **FunctionNotFoundAnalyzer**: Warns when a sub-orchestration call references a name that does not match any defined orchestrator in the compilation.
DURABLE2003 | Activity | Info | **FunctionNotFoundAnalyzer**: Reports when an activity function call references a name that does not match any defined activity in the compilation. If the function is defined in another assembly, this diagnostic can be safely ignored. Static resolution across referenced assemblies is not supported.
DURABLE2004 | Orchestration | Info | **FunctionNotFoundAnalyzer**: Reports when a sub-orchestration call references a name that does not match any defined orchestrator in the compilation. If the function is defined in another assembly, this diagnostic can be safely ignored. Static resolution across referenced assemblies is not supported.

## Release 0.1.0

Expand Down
4 changes: 2 additions & 2 deletions src/Analyzers/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,13 @@
<value>Use '{0}' instead of '{1}'</value>
</data>
<data name="ActivityNotFoundAnalyzerMessageFormat" xml:space="preserve">
<value>The activity function '{0}' was not found in the current compilation. Ensure the activity is defined and the name matches exactly.</value>
<value>The activity function '{0}' was not found in the current compilation. Ensure the activity is defined and the name matches exactly. If the function is defined in another assembly, this diagnostic can be safely ignored. Static resolution across referenced assemblies is not supported.</value>
</data>
<data name="ActivityNotFoundAnalyzerTitle" xml:space="preserve">
<value>Activity function not found</value>
</data>
<data name="SubOrchestrationNotFoundAnalyzerMessageFormat" xml:space="preserve">
<value>The sub-orchestration '{0}' was not found in the current compilation. Ensure the orchestrator is defined and the name matches exactly.</value>
<value>The sub-orchestration '{0}' was not found in the current compilation. Ensure the orchestrator is defined and the name matches exactly. If the function is defined in another assembly, this diagnostic can be safely ignored. Static resolution across referenced assemblies is not supported.</value>
</data>
<data name="SubOrchestrationNotFoundAnalyzerTitle" xml:space="preserve">
<value>Sub-orchestration not found</value>
Expand Down
Loading