Skip to content

Commit e77af14

Browse files
authored
ESRP sign the packages to be compliant for release (#210)
* ESRP sign the packages to be compliant for release * skip signing pub to local
1 parent e47a5a1 commit e77af14

File tree

5 files changed

+25
-14
lines changed

5 files changed

+25
-14
lines changed

.github/workflows/build-validation.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ jobs:
131131
uses: gradle/gradle-build-action@v2
132132

133133
- name: Publish to local
134-
run: ./gradlew publishToMavenLocal
134+
run: ./gradlew publishToMavenLocal -PskipSigning
135135

136136
- name: Build azure functions sample
137137
run: ./gradlew azureFunctionsPackage
@@ -170,7 +170,7 @@ jobs:
170170
uses: gradle/gradle-build-action@v2
171171

172172
- name: Publish to local
173-
run: ./gradlew publishToMavenLocal
173+
run: ./gradlew publishToMavenLocal -PskipSigning
174174

175175
- name: Build azure functions sample
176176
run: ./gradlew azureFunctionsPackage

azurefunctions/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ publishing {
7777
}
7878
}
7979

80-
// TODO: manual signing temporarily disabled, in favor of 1ES signing utils
81-
//signing {
82-
// sign publishing.publications.mavenJava
83-
//}
80+
signing {
81+
required = !project.hasProperty("skipSigning")
82+
sign publishing.publications.mavenJava
83+
}
8484

8585
java {
8686
withSourcesJar()

azuremanaged/build.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,11 @@ publishing {
110110
}
111111
}
112112

113+
signing {
114+
required = !project.hasProperty("skipSigning")
115+
sign publishing.publications.mavenJava
116+
}
117+
113118
java {
114119
withSourcesJar()
115120
withJavadocJar()

client/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,10 @@ publishing {
173173
}
174174
}
175175

176-
// TODO: manual signing temporarily disabled, in favor of 1ES signing
177-
//signing {
178-
// sign publishing.publications.mavenJava
179-
//}
176+
signing {
177+
required = !project.hasProperty("skipSigning")
178+
sign publishing.publications.mavenJava
179+
}
180180

181181
java {
182182
withSourcesJar()

eng/templates/build.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ jobs:
88
artifact: drop
99
sbomBuildDropPath: $(System.DefaultWorkingDirectory)
1010
sbomPackageName: 'Durable Task / Durable Functions Java SBOM'
11-
1211
steps:
1312
- checkout: self
1413

@@ -25,9 +24,15 @@ jobs:
2524
jdkArchitectureOption: 'x64'
2625
publishJUnitResults: false
2726
tasks: clean assemble
28-
displayName: Assemble durabletask-client and durabletask-azure-functions
27+
displayName: Assemble durabletask-client and durabletask-azure-functions and durabletask-azuremanaged
28+
29+
# the secring.gpg file is required to sign the artifacts, it's generated from GnuPG, and it's stored in the library of the durabletaskframework ADO
30+
- task: DownloadSecureFile@1
31+
name: gpgSecretFile
32+
displayName: 'Download GPG secret file'
33+
inputs:
34+
secureFile: 'secring.gpg'
2935

30-
# TODO: add 1ES-level signing
3136
- task: Gradle@3
3237
inputs:
3338
workingDirectory: ''
@@ -37,7 +42,8 @@ jobs:
3742
jdkVersionOption: 1.11
3843
jdkArchitectureOption: 'x64'
3944
tasks: publish
40-
displayName: Publish durabletask-client and durabletask-azure-functions
45+
options: '-Psigning.keyId=$(gpgSignKey) -Psigning.password=$(gpgSignPassword) -Psigning.secretKeyRingFile=$(gpgSecretFile.secureFilePath)'
46+
displayName: Publish durabletask-client and durabletask-azure-functions and durabletask-azuremanaged
4147

4248
- task: CopyFiles@2
4349
displayName: 'Copy publish file to Artifact Staging Directory'

0 commit comments

Comments
 (0)