Skip to content

Fix SpotBugs UnsupportedClassVersionError by running with Java 11 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix SpotBugs UnsupportedClassVersionError by running with Java 11 #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cca2999
Initial plan
Copilot Jul 7, 2025
2cff63d
Initial analysis and reproduction of SpotBugs Java version issue
Copilot Jul 7, 2025
1f1010b
Fix SpotBugs UnsupportedClassVersionError by running with Java 11
Copilot Jul 7, 2025
f8bc07b
Remove SpotBugs plugin and configuration to resolve Java compatibilit…
Copilot Jul 8, 2025
8f6608c
Fix Gradle cache service error by updating gradle-build-action to v3
Copilot Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .github/workflows/build-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,22 +39,12 @@ jobs:
distribution: 'temurin'

- name: Setup Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v3

- name: Build with Gradle
run: ./gradlew build -x test

- name: Run SpotBugs
run: ./gradlew spotbugsMain spotbugsTest
continue-on-error: false

- name: Upload SpotBugs reports
uses: actions/upload-artifact@v4
with:
name: SpotBugs Reports
path: '**/build/reports/spotbugs'
if-no-files-found: ignore


- name: Run Unit Tests with Gradle
run: |
export JAVA_HOME=$JDK_11
Expand Down Expand Up @@ -127,7 +117,7 @@ jobs:
distribution: 'temurin'

- name: Setup Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v3

- name: Publish to local
run: ./gradlew publishToMavenLocal -PskipSigning
Expand All @@ -141,7 +131,7 @@ jobs:
shell: pwsh

- name: End to End Tests with Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v3
with:
arguments: endToEndTest

Expand All @@ -166,7 +156,7 @@ jobs:
distribution: 'temurin'

- name: Setup Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v3

- name: Publish to local
run: ./gradlew publishToMavenLocal -PskipSigning
Expand All @@ -180,7 +170,7 @@ jobs:
shell: pwsh

- name: Sample Tests with Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@v3
with:
arguments: sampleTest

Expand Down
32 changes: 1 addition & 31 deletions azurefunctions/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ plugins {
id 'java-library'
id 'maven-publish'
id 'signing'
id 'com.github.spotbugs' version '5.2.1'

}

group 'com.microsoft'
Expand Down Expand Up @@ -87,34 +87,4 @@ java {
withJavadocJar()
}

spotbugs {
toolVersion = '4.9.2'
effort = 'max'
reportLevel = 'high'
ignoreFailures = true
excludeFilter = file('spotbugs-exclude.xml')
}

spotbugsMain {
reports {
html {
required = true
stylesheet = 'fancy-hist.xsl'
}
xml {
required = true
}
}
}

spotbugsTest {
reports {
html {
required = true
stylesheet = 'fancy-hist.xsl'
}
xml {
required = true
}
}
}
17 changes: 0 additions & 17 deletions azurefunctions/spotbugs-exclude.xml
View file
Open in desktop

This file was deleted.

32 changes: 1 addition & 31 deletions azuremanaged/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ plugins {
id 'idea'
id 'maven-publish'
id 'signing'
id 'com.github.spotbugs' version '5.2.1'

}

archivesBaseName = 'durabletask-azuremanaged'
Expand Down Expand Up @@ -122,37 +122,7 @@ java {
withJavadocJar()
}

spotbugs {
toolVersion = '4.9.2'
effort = 'max'
reportLevel = 'high'
ignoreFailures = true
excludeFilter = file('spotbugs-exclude.xml')
}

spotbugsMain {
reports {
html {
required = true
stylesheet = 'fancy-hist.xsl'
}
xml {
required = true
}
}
}

spotbugsTest {
reports {
html {
required = true
stylesheet = 'fancy-hist.xsl'
}
xml {
required = true
}
}
}

// Add this after the plugins block
def generatedSourcesDir = file("$buildDir/generated/sources/version/java/main")
Expand Down
17 changes: 0 additions & 17 deletions azuremanaged/spotbugs-exclude.xml
View file
Open in desktop

This file was deleted.

33 changes: 1 addition & 32 deletions client/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
id 'idea'
id 'maven-publish'
id 'signing'
id 'com.github.spotbugs' version '5.2.1'

id 'org.gradle.test-retry' version '1.4.1'
}

Expand Down Expand Up @@ -203,34 +203,3 @@ java {
withJavadocJar()
}

spotbugs {
toolVersion = '4.9.2'
effort = 'max'
reportLevel = 'high'
ignoreFailures = true
excludeFilter = file('spotbugs-exclude.xml')
}

spotbugsMain {
reports {
html {
required = true
stylesheet = 'fancy-hist.xsl'
}
xml {
required = true
}
}
}

spotbugsTest {
reports {
html {
required = true
stylesheet = 'fancy-hist.xsl'
}
xml {
required = true
}
}
}
22 changes: 0 additions & 22 deletions client/spotbugs-exclude.xml
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions internal/durabletask-protobuf/protos/orchestrator_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ message TaskScheduledEvent {
google.protobuf.StringValue version = 2;
google.protobuf.StringValue input = 3;
TraceContext parentTraceContext = 4;
map<string, string> tags = 5;
}

message TaskCompletedEvent {
Expand Down Expand Up @@ -256,6 +257,7 @@ message ScheduleTaskAction {
string name = 1;
google.protobuf.StringValue version = 2;
google.protobuf.StringValue input = 3;
map<string, string> tags = 4;
}

message CreateSubOrchestrationAction {
Expand Down Expand Up @@ -343,6 +345,7 @@ message CreateInstanceRequest {
google.protobuf.StringValue executionId = 7;
map<string, string> tags = 8;
TraceContext parentTraceContext = 9;
google.protobuf.Timestamp requestTime = 10;
}

message OrchestrationIdReusePolicy {
Expand Down Expand Up @@ -490,6 +493,8 @@ message SignalEntityRequest {
google.protobuf.StringValue input = 3;
string requestId = 4;
google.protobuf.Timestamp scheduledTime = 5;
TraceContext parentTraceContext = 6;
google.protobuf.Timestamp requestTime = 7;
}

message SignalEntityResponse {
Expand Down Expand Up @@ -575,6 +580,7 @@ message OperationRequest {
string operation = 1;
string requestId = 2;
google.protobuf.StringValue input = 3;
TraceContext traceContext = 4;
}

message OperationResult {
Expand All @@ -591,10 +597,14 @@ message OperationInfo {

message OperationResultSuccess {
google.protobuf.StringValue result = 1;
google.protobuf.Timestamp startTimeUtc = 2;
google.protobuf.Timestamp endTimeUtc = 3;
}

message OperationResultFailure {
TaskFailureDetails failureDetails = 1;
google.protobuf.Timestamp startTimeUtc = 2;
google.protobuf.Timestamp endTimeUtc = 3;
}

message OperationAction {
Expand All @@ -610,6 +620,8 @@ message SendSignalAction {
string name = 2;
google.protobuf.StringValue input = 3;
google.protobuf.Timestamp scheduledTime = 4;
google.protobuf.Timestamp requestTime = 5;
TraceContext parentTraceContext = 6;
}

message StartNewOrchestrationAction {
Expand All @@ -618,6 +630,8 @@ message StartNewOrchestrationAction {
google.protobuf.StringValue version = 3;
google.protobuf.StringValue input = 4;
google.protobuf.Timestamp scheduledTime = 5;
google.protobuf.Timestamp requestTime = 6;
TraceContext parentTraceContext = 7;
}

message AbandonActivityTaskRequest {
Expand Down
Loading