Skip to content

Update EntityInstanceId.parse signature #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andystaples wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update EntityInstanceId.parse signature #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71a3012
Update EntityInstanceId.parse signature
andystaples Dec 5, 2025
4e7eeeb
Fix linting
andystaples Dec 5, 2025
196adbe
Update docstring, fix usage
andystaples Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion durabletask/entities/entity_instance_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def __lt__(self, other):
return str(self) < str(other)

@staticmethod
def parse(entity_id: str) -> Optional["EntityInstanceId"]:
def parse(entity_id: str) -> "EntityInstanceId":
"""Parse a string representation of an entity ID into an EntityInstanceId object.

Parameters
Expand Down
5 changes: 3 additions & 2 deletions durabletask/entities/entity_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ def __init__(self,

@staticmethod
def from_entity_response(entity_response: pb.GetEntityResponse, includes_state: bool):
entity_id = EntityInstanceId.parse(entity_response.entity.instanceId)
if not entity_id:
try:
entity_id = EntityInstanceId.parse(entity_response.entity.instanceId)
except ValueError:
raise ValueError("Invalid entity instance ID in entity response.")
entity_state = None
if includes_state:
Expand Down
10 changes: 6 additions & 4 deletions durabletask/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,8 +750,9 @@ def _execute_entity_batch(
for operation in req.operations:
start_time = datetime.now(timezone.utc)
executor = _EntityExecutor(self._registry, self._logger)
entity_instance_id = EntityInstanceId.parse(instance_id)
if not entity_instance_id:
try:
entity_instance_id = EntityInstanceId.parse(instance_id)
except ValueError:
raise RuntimeError(f"Invalid entity instance ID '{operation.requestId}' in entity operation request.")

operation_result = None
Expand Down Expand Up @@ -1656,8 +1657,9 @@ def process_event(
raise _get_wrong_action_type_error(
entity_call_id, expected_method_name, action
)
entity_id = EntityInstanceId.parse(event.entityOperationCalled.targetInstanceId.value)
if not entity_id:
try:
entity_id = EntityInstanceId.parse(event.entityOperationCalled.targetInstanceId.value)
except ValueError:
raise RuntimeError(f"Could not parse entity ID from targetInstanceId '{event.entityOperationCalled.targetInstanceId.value}'")
ctx._entity_task_id_map[event.entityOperationCalled.requestId] = (entity_id, entity_call_id)
elif event.HasField("entityOperationSignaled"):
Expand Down
Loading