Skip to content

fix: correct "caracters" typo in error message#186

Merged
ayeshurun merged 222 commits intomicrosoft:mainfrom
ayeshurun:copilot/fix-error-message-spelling
Mar 12, 2026
Merged

fix: correct "caracters" typo in error message#186
ayeshurun merged 222 commits intomicrosoft:mainfrom
ayeshurun:copilot/fix-error-message-spelling

Conversation

@ayeshurun
Copy link
Copy Markdown
Collaborator

📥 Pull Request

✨ Description of new changes

The WARNING_INVALID_SPECIAL_CHARACTERS constant in fab_constant.py misspells "characters" as "caracters", surfacing in user-facing error messages like:

x table load: [Special caracters not supported for this item type] Lakehouse name '...' contains unsupported special characters
  • Fixed the typo in src/fabric_cli/core/fab_constant.py
Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Error message contains incorrect spellings for the word "characters"</issue_title>
<issue_description>### Bug Description

Scenario - while loading data to a Lakehouse table using table load command, the CLI throws an error. The error message has incorrect spellings for the word "character". It's misspelt as "caracters".

[Error message]
fab:/ws_secr-test-001_oap.Workspace$ table load dummylh.Lakehouse/Tables/dbo/dummy --file load public_holidays_lh.Lakehouse/Files/public_holidays.p
arquet --format format=parquet
Loading 'dummy' table. It may take some time...
x table load: [Special caracters not supported for this item type] Lakehouse name 'load public_holidays_lh' contains unsupported special characters

fabric-cli version

1.4.0

Python version

Python 3.13.12

Operating System

Windows

CLI Mode

Interactive mode

Authentication Method

Interactive browser login

Steps to Reproduce

  1. Login to fab cli using interactive login
  2. At the CLI, run table load command.
  3. In my env, I am using a schema-enabled lakehouse and loading a parquet file from /Files to a table using table load command.

Expected Behavior

In the error message - "characters" is misspelt as "caracters"

Actual Behavior

Please see Expected Behaviour section.

Additional Context

No response

Possible Solution

No response</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

ayeshurun and others added 30 commits September 17, 2025 17:11
chore: Introduce release workflowc
Alon Yeshurun and others added 23 commits February 19, 2026 16:02
- Merge Needs Maintainer Input and Needs Team Review into single
  Needs Team Review category in question-triage prompt
- Remove duplicate needs author feedback label from post-processing
  (action's ai:* label is sufficient)
- Remove ai:* label cleanup (keep action's assessment labels)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract CLI commands, flags, item types, auth methods, and error
codes from actual source files. Inject into system prompt (not issue
body) so AI backs up answers with real codebase data. Comments and
issue body stay clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
All AI triage comments now end with a footer instructing users
to tag @microsoft/fabric-cli-dev if the issue needs team attention
but wasn't escalated by the AI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Approach A (Action): github/ai-assessment-comment-labeler with codebase context injection
- Approach B (Code Agent): Custom scripts/ai_triage.py that greps source code and injects into prompt
- Both trigger on 'needs triage' label and post tagged comments (🅰️/🅱️)
- Both include collapsible label decision tables in comments
- Labels suppressed on both for fair testing
- Added CLI doc page URLs to all 3 prompt files

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- A: Use yaml.safe_load/dump to avoid YAML alias errors from markdown **bold**
- A: Remove bold markdown from injected context text
- B: Reduce code context limits (30K total, 4K/file, 8 files max)
- B: Add API error details to stderr for debugging

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Bug: Potential Bug and Needs Team Review → Escalated to team
- Question: Tied each category explicitly to its footer
- Feature: Tied each category explicitly to its footer
- Removed stale Codebase Reference instruction from feature prompt

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove numbered dimension checklists from all 3 prompts
- Instruct model to skip adequate aspects, highlight only missing/wrong/notable
- Reduce target length from 3-5 to 2-4 paragraphs
- Trim verbose preamble in ai_triage.py code context header

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Valuable Enhancement → 📋 Backlog candidate (no escalation)
- Help Wanted → 🤝 Community contribution welcome
- Out of Scope → ✅ No action needed
- Add 'needs discussion' to needsHumanReview in both workflows

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add tailored PEP/RFC/convention references to each prompt:
- Bug: packaging, CLI conventions, HTTP/REST, auth, file I/O, runtime
- Question: packaging, CLI conventions, HTTP/REST, auth, data formats
- Feature: CLI conventions, packaging, HTTP/REST, backward compat, auth

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…mpts

- Remove Approach B (agent workflow + ai_triage.py), archived on branch
- Move codebase reference from pipeline build step into prompt files
- Prompts now self-contained: commands, flags, item types, auth, hidden entities
- Remove /tmp/prompts indirection, use .github/prompts directly
- Clean up A/B testing artifacts (tagged comments, approach labels)
- Restore phase control flags (SUPPRESS_LABELS + SUPPRESS_COMMENTS)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…inks

Reference https://microsoft.github.io/fabric-cli/essentials/resource_types/
instead of static lists, keeping prompts always up to date.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Copilot AI requested a review from a team as a code owner March 10, 2026 13:50
@ayeshurun ayeshurun requested a review from shirasassoon March 12, 2026 08:10
@ayeshurun ayeshurun merged commit a14137c into microsoft:main Mar 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error message contains incorrect spellings for the word "characters"

4 participants