fix: Add support for create connection with on-premises gateway#54
Merged
aviatco merged 14 commits intomicrosoft:mainfrom Nov 12, 2025
Merged
Conversation
…ttps://github.com/aviatco/fabric-cli into dev/aviatcohen/create-connection-onpremisesgateway
ayeshurun
reviewed
Nov 4, 2025
ayeshurun
reviewed
Nov 4, 2025
ayeshurun
reviewed
Nov 4, 2025
ayeshurun
reviewed
Nov 4, 2025
ayeshurun
reviewed
Nov 4, 2025
ayeshurun
reviewed
Nov 4, 2025
ayeshurun
reviewed
Nov 4, 2025
Co-authored-by: Alon Yeshurun <98805507+ayeshurun@users.noreply.github.com>
may-hartov
previously approved these changes
Nov 5, 2025
added 2 commits
November 6, 2025 07:26
…ttps://github.com/aviatco/fabric-cli into dev/aviatcohen/create-connection-onpremisesgateway
ayeshurun
reviewed
Nov 10, 2025
ayeshurun
reviewed
Nov 11, 2025
ayeshurun
reviewed
Nov 11, 2025
ayeshurun
reviewed
Nov 11, 2025
Collaborator
|
please add changie entry |
ayeshurun
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
✨ Description of new changes
Overview
Enhanced the fabric CLI to support creating connections with on-premises gateway connectivity, including proper parameter validation and credential handling for gateway-specific scenarios according to API documentation.
Key Changes
Connection Parameter Validation (
fab_cmd_mkdir_utils.py)onpremisesgatewayconnectivity type in credential validationgatewayIdandencryptedCredentialsparametersGateway Credential Handling
_validate_credential_params()function to handle on-premises gateway authentication flowsvaluesparameter structure specific to on-premises gateway connectivityError Handling Improvements
AttributeErrorwhen processing malformed credential dataTechnical Details
onpremisesgatewaysupport.gatewayId,encryptedCredentialsfor on-premises gateway connectionsvaluesparameter containing gateway authentication detailsImportant Note
Testing
This enhancement enables users to create secure connections through on-premises data gateways, expanding the CLI's connectivity options for hybrid cloud scenarios.