Skip to content

fix: --output_format respects argument#56

Merged
ayeshurun merged 11 commits intomicrosoft:mainfrom
Guust-Franssens:fix/auth_status_output_format
Nov 17, 2025
Merged

fix: --output_format respects argument#56
ayeshurun merged 11 commits intomicrosoft:mainfrom
Guust-Franssens:fix/auth_status_output_format

Conversation

@Guust-Franssens
Copy link
Copy Markdown
Contributor

Description

Fixes #55 - The --output_format flag was not being respected for the fab auth status command, causing JSON output to be displayed as text format instead.

Changes

  • Modified the auth status command to properly respect the --output_format argument
  • When --output_format json is specified, the command now returns machine-readable JSON output instead of formatted text

Related Issue

Closes #55

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Tested with fab auth status --output_format json
  • Verified JSON output is returned in machine-readable format
  • Verified default text format still works as expected

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have tested the changes locally

@Guust-Franssens Guust-Franssens requested a review from a team as a code owner November 1, 2025 15:43
@Guust-Franssens
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@Guust-Franssens
Copy link
Copy Markdown
Contributor Author

@ayeshurun, @ohadedry ready for review

@ayeshurun
Copy link
Copy Markdown
Collaborator

Thank you for your contribution to the CLI project!

We will begin triaging the associated issue shortly. Upon completion of the triage process, we will remove the needs triage label and, if appropriate, apply the help wanted label to indicate that external contributions are welcome (at first glance, the issue seems appropriate for that designation). Following this, we will proceed with reviewing this pull request and provide feedback accordingly.

As a reminder, all contributions must adhere to our contribution guidelines.

In particular, pull requests should be linked to an approved issue that includes the help wanted label. We kindly ask that these guidelines be followed for all future contributions.

Thank you once again — we look forward to continued collaboration.

@Guust-Franssens
Copy link
Copy Markdown
Contributor Author

@ayeshurun Thanks for the reply, after looking at the contribution guidelines I was perhaps a bit hasty ;)
I added the changie documentation as well.

@aviatco lmk if you need any other changes.

@Guust-Franssens Guust-Franssens force-pushed the fix/auth_status_output_format branch from af6d387 to 2bf97fe Compare November 13, 2025 17:53
@Guust-Franssens
Copy link
Copy Markdown
Contributor Author

@aviatco if there are no more remarks then on my side is ready to be merged.

ayeshurun
ayeshurun previously approved these changes Nov 17, 2025
@ayeshurun
Copy link
Copy Markdown
Collaborator

@Guust-Franssens it looks like one test has failed, please ensure all tests are passing, only then we will be able to merge.

@Guust-Franssens
Copy link
Copy Markdown
Contributor Author

Guust-Franssens commented Nov 17, 2025

@ayeshurun the failing test IMO had to be updated as to reflect the new implementation that uses print_output_format(). I did so in 193b6ac.

@ayeshurun ayeshurun merged commit f7bf1d7 into microsoft:main Nov 17, 2025
9 checks passed
@Guust-Franssens Guust-Franssens deleted the fix/auth_status_output_format branch November 17, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] --output_format not respected for "fab auth status"

3 participants