fix(LRO): remove redundant call to /operations/{id}/result when no location header is present#69
Merged
may-hartov merged 2 commits intomicrosoft:mainfrom Nov 24, 2025
Conversation
may-hartov
requested review from
aliabufoul,
aviatco,
ayeshurun and
ohadedry
aliabufoul
reviewed
Nov 19, 2025
aliabufoul
approved these changes
Nov 19, 2025
Collaborator
|
@may-hartov can you please add unit test verify this case? that we skip the second call in case no headers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_poll_operationfunction to check for the presence of aLocationheader before fetching operation results, ensuring correct handling of operation responses. If theLocationheader is not present, the response status code is set to 200 and the original response is returned.Context
When the CLI receives a success response from the LRO API, it automatically calls /operations/{id}/result to retrieve the result payload. However, this payload is only available when the operation returns success and includes a Location header in the response. If the header is missing, the /result call is unnecessary and will return the error operationHasNoResult.