Skip to content

feat: Add --format to export command#70

Merged
aviatco merged 17 commits intomicrosoft:mainfrom
jkafrouni:dev/notebook_export_formats
Dec 24, 2025
Merged

feat: Add --format to export command#70
aviatco merged 17 commits intomicrosoft:mainfrom
jkafrouni:dev/notebook_export_formats

Conversation

@jkafrouni
Copy link
Copy Markdown
Contributor

@jkafrouni jkafrouni commented Nov 20, 2025

✨ Description of new changes

Fixes #24 by adding --format to the export command parser and setting the right underlying format if user selects .py or .ipynb, similar to how the import command supports format.
If no format is selected and the user is exporting a notebook, will continue using the default export format for notebooks which is ipynb.

@jkafrouni jkafrouni requested a review from a team as a code owner November 20, 2025 03:03
@jkafrouni
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree [company="Microsoft"]

@jkafrouni
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@ayeshurun
Copy link
Copy Markdown
Collaborator

@jkafrouni please add test covering the export format scenario. You can use notebook .py formatting example in the test

@aviatco
Copy link
Copy Markdown
Collaborator

aviatco commented Nov 23, 2025

@jkafrouni in the description you meant --format and not --export am I correct?

@jkafrouni
Copy link
Copy Markdown
Contributor Author

@jkafrouni in the description you meant --format and not --export am I correct?

Correct, my bad, just edited

@jkafrouni
Copy link
Copy Markdown
Contributor Author

@jkafrouni please add test covering the export format scenario. You can use notebook .py formatting example in the test

Just added two tests for success and failure

@aviatco aviatco merged commit 8f57a3f into microsoft:main Dec 24, 2025
9 checks passed
@ayeshurun ayeshurun linked an issue Mar 18, 2026 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support 'format' parameter in the export command [FEATURE] Allow notebook exports in .py format

3 participants