fix: remove unregistered internal packages from install_requires (dependency confusion)#235
Open
x4v13r64 wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
…endency confusion)
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four
setup.pyfiles in this repo declare internal packages (vibe-core,vibe-common,vibe_core) asinstall_requiresdependencies using their bare PyPI-style names. None of these package names are registered on PyPI.Because they appear in
install_requires, pip resolves them transitively from PyPI when any of the affected packages is installed. An attacker who registersvibe-coreorvibe-commonon PyPI (PEP 503 normalisation means one registration covers both spellings) gains code execution in any environment installingvibe_agent,vibe_common,vibe_server, orvibe_notebook.This PR removes the four unregistered names from
install_requiresin:src/vibe_agent/setup.py— removesvibe-core,vibe-commonsrc/vibe_common/setup.py— removesvibe_coresrc/vibe_server/setup.py— removesvibe-core,vibe-commonsrc/vibe_notebook/setup.py— removesvibe_coreSecurity impact: A single PyPI registration compromises all four components simultaneously and gives the attacker access to the Azure credentials (identity tokens, storage keys, Cosmos DB connections) these packages are configured to use.